-
Notifications
You must be signed in to change notification settings - Fork 299
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Compression changes to eo-learn #731
Conversation
@zigaLuksic turns out that backwards compatibility already worked out of the box, since the featureIO objects retained the ability to handled loading of compressed/uncompressed objects I added back the compression_level parameter as discussed, and added the EODeprecation warning on the save task and the save method. I removed the parameter from the docs, though. Lastly, I added tests for checking the compression deprecation warning, and augmented a test for checking backwards compatibility loading and proper cleanup if different compressions are present (from before) |
Slight correction, the |
Also, I wasn't sure if I should keep the compression capabilities in the |
I see no reason to keep it, since it would control only part of the compression behaviour (for numpy and geodata) which we dont really want to be changed (except for tests) |
Changes:
compression_level
parameter removed