Detect dsn hostname #17
Conversation
src/ui/popup.tsx
Outdated
| )} | ||
| </li> | ||
| <li> | ||
| <p className="text-muted location"> | ||
| <span className="text-muted location"> | ||
| Sending events to <b>{this.state.dsn.includes(SENTRY_DOMAIN) ? "SaaS" : "Self-Hosted Sentry"}</b> via <a href={this.state.dsn}>{this.state.dsn}</a> |
There was a problem hiding this comment.
@cstavitsky
It may still be going to sentry.io but via nginx reverse proxy / etc.
How about we just output the domain of the DSN and call it a day.
- i.e. sending to sentry.io as project ID 123
- i.e. sending to nginx.reddit.com/sentry as project ID 123
There was a problem hiding this comment.
with the base domain, folks can then investigate further to see if its truly targeting on-premise or saas
There was a problem hiding this comment.
@ndmanvar Ahhh didn't think of that, very good point...
i.e. sending to sentry.io as project ID 123
i.e. sending to nginx.reddit.com/sentry as project ID 123
do we need to provide any instructions to AEs in the plugin itself (i.e. link to admin projects page)? Are AEs aware of how to look up project IDs in Admin and determine whether those are SaaS or Self-hosted?
There was a problem hiding this comment.
nope, don't worry about linking the AEs to the right info.
Some / most are not, but we can train them on it.
(also this is a public repo so we can't link them to our admin/etc)
|
once we get this merged. let's announce the updates and get folks to upgrade |
|
are you down to present this at next Sales/CS Bi-weekly? |
|
i can go over how to install/re-install, you go over the cool new stuff? |
|
neil to clone down and test out branch |
|
works perfectly when installed via bundle (e.g. npm/yarn) install/etc. when sending to sentry.io and other domain (see nbc-peacock, 3rd image)
|
|
does not work when it is included via CDN [ we can create another issue for that one. I don't think it's too important as most folks will bundle it ]
|
|
@cstavitsky verified ✅ |
Feature details
Screenshots