fix: dont compute so many fibonacci numbers #90
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I tried running the demo on an iPhone 14, and it crashes with an arithmetic overflow when computing around the 650th fibonacci number. It is probably due to running an optimized build? Doubt it's due to the different device, since both my phone and mac are running an apple silicon arm chip.
Just dialing down the limit from 4000 to 500 fib numbers fixed it.