Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: dont compute so many fibonacci numbers #90

Merged
merged 1 commit into from
Aug 13, 2024

Conversation

armcknight
Copy link
Collaborator

I tried running the demo on an iPhone 14, and it crashes with an arithmetic overflow when computing around the 650th fibonacci number. It is probably due to running an optimized build? Doubt it's due to the different device, since both my phone and mac are running an apple silicon arm chip.

Just dialing down the limit from 4000 to 500 fib numbers fixed it.

Copy link

codecov bot commented May 5, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 39.526%. Comparing base (75800b2) to head (598f80c).

Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff              @@
##            master       #90       +/-   ##
=============================================
+ Coverage   37.655%   39.526%   +1.870%     
=============================================
  Files           10        10               
  Lines          802       802               
  Branches       255       255               
=============================================
+ Hits           302       317       +15     
+ Misses         492       476       -16     
- Partials         8         9        +1     
Files Coverage Δ
EmpowerPlant/EmpowerPlantViewController.swift 61.172% <0.000%> (ø)

... and 1 file with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 75800b2...598f80c. Read the comment docs.

@kpujjigit kpujjigit merged commit b4c2a47 into master Aug 13, 2024
3 of 5 checks passed
@kpujjigit kpujjigit deleted the armcknight/fix/fibonacci-crash branch August 13, 2024 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants