Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(clickhouse): update ClickHouse version to 23.3.19.32 #1552

Merged
merged 1 commit into from
Oct 16, 2024

Conversation

patsevanton
Copy link
Contributor

@patsevanton patsevanton commented Oct 16, 2024

Description

@Mokto This pull request updates the ClickHouse version in the Helm chart to 23.3.19.32. The new version aligns with with the upgrade script located at install/upgrade-clickhouse.sh.

Changes

Updated the appVersion in the Chart.yaml file from 22.8.15.23 to 23.3.19.32.

Update plan:
sentry clickhouse
24.7.1 21.8.13.6
24.8.0 23.3.19.32
24.9.0 23.3.19.32

Related Issues

Related Pull Requests:

i tested sentry 24.8.0 and clickhouse chart version 3.12.0 with 22.8.15.23
sentry-snuba-migrate-pkpmh snuba-migrate snuba.clickhouse.errors.ClickhouseError: DB::Exception: Codec DoubleDelta does not accept any arguments. Stack trace:

i tested sentry 24.8.0 and clickhouse version 23.3.19.32 - no errors

@Mokto Mokto merged commit 05bcae5 into sentry-kubernetes:develop Oct 16, 2024
2 checks passed
@Mokto Mokto mentioned this pull request Oct 16, 2024
@patsevanton patsevanton deleted the clickhouse-23-3 branch October 16, 2024 09:09
@adonskoy
Copy link
Contributor

Do we need to update the clickhouse version sequentially? If so, then it should have been a new major version

@patsevanton
Copy link
Contributor Author

patsevanton commented Oct 16, 2024

I think yes
https://github.com/getsentry/self-hosted/blob/master/install/upgrade-clickhouse.sh#L20
Which clickhouse version do you mean?

I think the upgrade plan will be like this:
sentry clickhouse
24.7.1 21.8.13.6
24.7.1 22.8.15.23
24.7.1 23.3.19.32
24.8.0 23.3.19.32
24.9.0 23.3.19.32

@Mokto
Copy link
Contributor

Mokto commented Oct 16, 2024

So let's update to Clickhouse on a minor/patch first 3.12.0

And then to 3.13.0 on a major?

@patsevanton
Copy link
Contributor Author

patsevanton commented Oct 16, 2024

@Mokto Do you mean like #1556 ?

@adonskoy
Copy link
Contributor

It looks like it is possible to update clickhouse directly to the latest major version, but it is recommended to shutdown the cluster before doing so

https://clickhouse.com/docs/en/operations/update#incremental-upgrades

@adonskoy
Copy link
Contributor

We can release a new major version of the sentry chart with an updated version of clickhouse and leave a recommendation in the readme to set the number of clickhouse replicas to 0 before updating

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants