Issue #35: High CPU Usage Due to Infinite Loop in IPMI Core library Connection.run()
#36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Implemented the ability to override the `pingPeriod`, allowing it to be set to `0` to disable keep-alive messages. * Added a delay (1 second) between retries to avoid tight looping and reduce CPU usage. * Included a check for thread interruption to allow graceful shutdown. * Modified the runner code to ensure that closable instances are properly closed.
NassimBtk
requested review from
MedMaalej,
bertysentry,
taha-c,
alexdgilbert,
TNohaic,
CherfaElyes and
SafaeAJ
…ite-loop-in-connection-classs-run-method
* Fixed javadoc.
…-connection-classs-run-method' of https://github.com/sentrysoftware/ipmi.git into feature/issue-35-high-cpu-usage-due-to-infinite-loop-in-connection-classs-run-method
NassimBtk
deleted the
feature/issue-35-high-cpu-usage-due-to-infinite-loop-in-connection-classs-run-method
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implemented the ability to override the
pingPeriod, allowing it to be set to0to disable keep-alive messages.Added a delay (1 second) between retries to avoid tight looping and reduce CPU usage.
Included a check for thread interruption to allow graceful shutdown.
Modified the runner code to ensure that closable instances are properly closed.