Explicitly states the SQS endpoint when creating SQS client #50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request questions
Which issue does this address
Issue number: #49
Why was change needed
This change enables support SQS VPC endpoints, and allows the code to work regardless of whether VPC endpoints are in use or not.
What does change improve
Previously when SQS VPC endpoints were in use the code fails as the endpoint must be explicitly stated.
Note: this is a 'minimal' change to the code, so is repetitive in nature modifying each client creation. This could be abstracted to a base class but this would require wider refactoring.