Updates for Reevaluate Functions for Exception Throwing

src/main/java/com/senzing/sdk/SzEngine.java

@@ -114,6 +114,14 @@ String deleteRecord(SzRecordKey recordKey, Set<SzFlag> flags)
      * Reevaluate the record identified by the data source code and record ID
      * from the specified {@link SzRecordKey}.
      * <p>
+     * If the data source code is not recognized then an {@link
+     * SzUnknownDataSourceException} is thrown but if the record for the
+     * record ID is not found, then the operation silently does nothing with
+     * no exception.  This is to ensure consistent behavior in case of a race
+     * condition with record deletion.  To ensure that the record was found,
+     * specify the {@link SzFlag#SZ_WITH_INFO} flag and check the returned
+     * INFO document for affected entities.
+     * <p>
      * The specified {@link Set} of {@link SzFlag} instances may contain any 
      * {@link SzFlag} value, but only flags belonging to the {@link
      * SzFlagUsageGroup#SZ_MODIFY} group will be recognized (other {@link SzFlag}
@@ -135,8 +143,6 @@ String deleteRecord(SzRecordKey recordKey, Set<SzFlag> flags)
      * @throws SzUnknownDataSourceException If an unrecognized data source
      *                                      code is specified.
      * 
-     * @throws SzNotFoundException If the record ID is not found.
-     * 
      * @throws SzException If a failure occurs.
      * 
      * @see SzFlag#SZ_WITH_INFO_FLAGS
@@ -149,6 +155,12 @@ String reevaluateRecord(SzRecordKey recordKey, Set<SzFlag> flags)
      * Reevaluate a resolved entity identified by the specified entity ID.
      * If the entity is not found then this method does nothing.
      * <p>
+     * If the entity for the entity ID is not found, then the operation
+     * silently does nothing with no exception.  This is to ensure consistent
+     * behavior in case of a race condition with entity re-resolve or unresolve.
+     * To ensure that the entity was found, specify the {@link SzFlag#SZ_WITH_INFO}
+     * flag and check the returned INFO document for affected entities.
+     * <p>
      * The specified {@link Set} of {@link SzFlag} instances may contain any 
      * {@link SzFlag} value, but only flags belonging to the {@link
      * SzFlagUsageGroup#SZ_MODIFY} group will be recognized (other {@link SzFlag}

src/main/java/com/senzing/sdk/core/SzCoreEnvironment.java

@@ -419,7 +419,6 @@ void handleReturnCode(int returnCode, NativeApi nativeApi)
             case 24:
             case 88:
                 throw new SzBadInputException(errorCode, message);
-            case 27: // this is going away
             case 2207:
                 throw new SzUnknownDataSourceException(errorCode, message);
             case 33:

src/test/java/com/senzing/sdk/core/SzCoreEngineWriteTest.java

@@ -655,8 +655,8 @@ public List<Arguments> getReevaluateRecordArguments() {
                 // do a good data source with a bad record ID
                 key = SzRecordKey.of(key.dataSourceCode(), key.recordId() + "-UNKNOWN");
 
-                // TODO(bcaceres) -- change this depending on the outcome of GDEV-3790
-                //exceptionType = SzNotFoundException.class;
+                // Per decision, reevaluate record silently does nothing if record ID not found
+                // exceptionType = SzNotFoundException.class;
 
                 break;
                 default:
@@ -758,15 +758,15 @@ public List<Arguments> getReevaluateEntityArguments() {
                 case 0:
                 // do a negative entity ID
                 entityId = -1 * entityId;
-                // TODO(bcaceres) -- change this depending on the outcome of GDEV-3790
-                //exceptionType = SzNotFoundException.class;
+                // Per decision, reevaluate entity silently does nothing if enitty ID not found
+                // exceptionType = SzNotFoundException.class;
 
                 break;
                 case 1:
                 // do a large entity that does not exist
                 entityId = 1000000000L;
-                // TODO(bcaceres) -- change this depending on the outcome of GDEV-3790
-                //exceptionType = SzNotFoundException.class;
+                // Per decision, reevaluate entity silently does nothing if enitty ID not found
+                // exceptionType = SzNotFoundException.class;
 
                 break;
                 default:
@@ -819,8 +819,8 @@ void testReevaluateEntity(Long          entityId,
                     }
                 } else {
                     assertEquals(SzCoreEngine.NO_INFO, result,
-                                "No INFO requested, but non-empty response received: "
-                                + testData);
+                                 "No INFO requested, but non-empty response received: "
+                                 + testData);
                 }
 
             } catch (Exception e) {