Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

impr: small usability improvements #481

Merged
merged 2 commits into from
Jan 31, 2025

Conversation

endre-seqera
Copy link
Member

@endre-seqera endre-seqera commented Jan 30, 2025

Small improvements and follow-ups to the cli:

1. when creating a new DataStudio validate the template that is provided:

➜ ./gradlew run -q --args="--insecure studios add -n my-studi4 -w 22117901918827 -t wrong-template-vscode -c 2rZkbXfTkiJxTVz18OJs3i"

 ERROR: DataStudio template 'wrong-template-vscode' is not one of available templates 
 '[cr.seqera.io/public/data-studio-jupyter:4.2.5-snapshot, cr.seqera.io/public/data-studio-rstudio:4.4.1-u1-snapshot, cr.seqera.io/public/data-studio-vscode:1.93.1-snapshot, cr.seqera.io/public/data-studio-xpra:6.2.0-r2-1-snapshot]'

2. when starting as new, allow for parent data studio name to be specified, not just ID:

➜ ./gradlew run -q --args="--insecure studios start-as-new -pn studio-that-was-never-started -n my-child-studio -w 22117901918827"

  Data Studio 57a05dda CREATED at [aaa / bbb] workspace.

3. when a studio is created with autostart, show the studio in the:

➜ ./gradlew run -q --args="--insecure studios add -n my-studi4 -w 22117901918827 -t cr.seqera.io/public/data-studio-jupyter:4.2.5-snapshot -c 2rZkbXfTkiJxTVz18OJs3i -a"

  Data Studio 720ad0ca CREATED at [aaa / bbb] workspace and auto started.

    http://localhost:8000//orgs/aaa/workspaces/bbb/studios/720ad0ca/connect

➜ ./gradlew run -q --args="--insecure studios start-as-new -pn studio-that-was-never-started -n my-child-studio-2 -w 22117901918827 -a"                               

  Data Studio 39b8c805 CREATED at [aaa / bbb] workspace and auto started.

    http://localhost:8000//orgs/aaa/workspaces/bbb/studios/39b8c805/connect

@endre-seqera endre-seqera merged commit 56e9fdf into master Jan 31, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants