Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename "Data studios" to "studios" + other small readability standarisation #486

Merged
merged 1 commit into from
Feb 3, 2025

Conversation

georgi-seqera
Copy link
Contributor

@georgi-seqera georgi-seqera commented Feb 3, 2025

Small fixes post verification of: https://seqera.atlassian.net/browse/PLAT-583

Fix sort of the tw studio checkpoints command (the list is already sorted from the backend, so just using the given sort instead of doing any sorting on the cli side, which is slightly broken).

/tw studios checkpoints -w data-studios/data-studios -n studio-ef6b

  Checkpoints at Studio studio-ef6b at [data-studios / data-studios] workspace:

     ID  | Name                   | Author         | Date Created                  | Date Saved
    -----+------------------------+----------------+-------------------------------+-------------------------------
     333 | studio-ef6b_1738341636 | georgi-hristov | Fri, 31 Jan 2025 16:40:36 GMT | Fri, 31 Jan 2025 17:59:29 GMT
     195 | studio-ef6b_1738229371 | georgi-hristov | Thu, 30 Jan 2025 09:29:31 GMT | Thu, 30 Jan 2025 09:34:33 GMT
     194 | studio-ef6b_1738068546 | georgi-hristov | Tue, 28 Jan 2025 12:49:06 GMT | Tue, 28 Jan 2025 14:05:07 GMT
     193 | studio-ef6b_1738068297 | georgi-hristov | Tue, 28 Jan 2025 12:44:57 GMT | Tue, 28 Jan 2025 12:48:42 GMT
     192 | studio-ef6b_1738067452 | georgi-hristov | Tue, 28 Jan 2025 12:30:52 GMT | Tue, 28 Jan 2025 12:36:13 GMT
     191 | studio-ef6b_1738062560 | georgi-hristov | Tue, 28 Jan 2025 11:09:20 GMT | Tue, 28 Jan 2025 11:56:53 GMT
     190 | studio-ef6b_1738061352 | georgi-hristov | Tue, 28 Jan 2025 10:49:12 GMT | Tue, 28 Jan 2025 10:56:07 GMT
     187 | studio-ef6b_1737997605 | georgi-hristov | Mon, 27 Jan 2025 17:06:45 GMT | Mon, 27 Jan 2025 17:09:32 GMT
./tw studios checkpoints -w data-studios/data-studios -n studio-c3f6

  Checkpoints at Studio studio-c3f6 at [data-studios / data-studios] workspace:

     ID  | Name                   | Author         | Date Created                 | Date Saved
    -----+------------------------+----------------+------------------------------+------------------------------
     344 | studio-c3f6_1738606010 | georgi-hristov | Mon, 3 Feb 2025 18:06:50 GMT | never
     343 | studio-c3f6_1738605260 | georgi-hristov | Mon, 3 Feb 2025 17:54:20 GMT | Mon, 3 Feb 2025 18:06:35 GMT

@georgi-seqera georgi-seqera marked this pull request as ready for review February 3, 2025 18:40
import picocli.CommandLine;
import picocli.CommandLine.Command;

import java.io.IOException;

@Command(
name = "checkpoints",
description = "List checkpoints for a data studios."
description = "List checkpoints for a studios."
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't it be singular?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good spot, thanks

@georgi-seqera georgi-seqera force-pushed the no-task/studios-cli-minor-improvements branch from a9298ea to 167c5bb Compare February 3, 2025 18:46
@georgi-seqera georgi-seqera merged commit b86d8d0 into master Feb 3, 2025
7 checks passed
@georgi-seqera georgi-seqera deleted the no-task/studios-cli-minor-improvements branch February 3, 2025 18:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants