Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating runner to use database versions and CI comparable to v7 #261

Merged
merged 18 commits into from
Feb 10, 2024
Merged
16 changes: 8 additions & 8 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -12,18 +12,18 @@ jobs:
fail-fast: false
matrix:
# node 10 is the minimum supported version for Sequelize 6
# node 14 is the minimum supported version for Sequelize 7
# node 16 is latest LTS (to keep updated)
node: [10, 14, 16]
# node 16 is the minimum supported version for Sequelize 7
# node 18 is latest LTS (to keep updated)
node: [10, 16, 18]
name: SQLite (sequelize 6 & 7, node ${{ matrix.node }})
runs-on: ubuntu-latest
env:
DIALECT: sqlite
steps:
- uses: actions/checkout@v2
- uses: actions/setup-node@v1
- uses: actions/setup-node@v3
with:
node-version: 14.x
node-version: ${{ matrix.node }}
- run: /bin/bash ./setup/prepare-ci.sh
- name: Execute SSCCE
run: npm run _test
Expand All @@ -33,7 +33,7 @@ jobs:
matrix:
postgres-version: [9.5, 10] # Does not work with 12
native: [true, false]
node: [10, 14, 16]
node: [10, 16, 18]
name: Postgres ${{ matrix.postgres-version }}${{ matrix.native && ' (native)' || '' }} (sequelize 6 & 7, node ${{ matrix.node }})
runs-on: ubuntu-latest
services:
Expand Down Expand Up @@ -61,7 +61,7 @@ jobs:
strategy:
fail-fast: false
matrix:
node: [10, 14, 16]
node: [10, 16, 18]
db:
- '{ name: "MySQL 5.7", image: "mysql:5.7", dialect: "mysql" }'
- '{ name: "MariaDB 10.3", image: "mariadb:10.3", dialect: "mariadb" }'
Expand Down Expand Up @@ -93,7 +93,7 @@ jobs:
strategy:
fail-fast: false
matrix:
node: [10, 14, 16]
node: [10, 16, 18]
mssql-version: [2017, 2019]
name: MSSQL ${{ matrix.mssql-version }} (sequelize 6 & 7, node ${{ matrix.node }})
runs-on: ubuntu-latest
Expand Down
2 changes: 1 addition & 1 deletion setup/runner.ts
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ async function wrappedRun() {
logBlue(heading);
logBlue(`${'-'.repeat(heading.length)}\n`);

if (majorNodeVersion >= 14) {
if (majorNodeVersion >= 16) {
const { run, testingOnDialects } = require('../src/sscce-sequelize-7');
if (!testingOnDialects.has(process.env.DIALECT!)) {
logRed(`Skipping dialect ${process.env.DIALECT} as it has been omitted from 'testingOnDialects'`);
Expand Down