Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid memory leak in loaned-message return path #97

Conversation

tobiasstarkwayve
Copy link
Contributor

See #85

This PR fixes a memory leak on the code path returning loaned messsages to the middleware.

@tobiasstarkwayve
Copy link
Contributor Author

@m-dahl Here is the patch I promised back in March (sorry, I got sidetracked in the meantime and only now had the time to come back to this).

I have roughly tested it on our Wayve-internal build of this, but not through the cargo path. I tried using the Dockerfiles in tests/, but wasn't able to get the build to run as it was looking for an "OUT_FILES" environment variable. Is there more documentation on how to run these? If not, could you double-check the changes and check that they work?

@m-dahl
Copy link
Collaborator

m-dahl commented Jun 18, 2024

Thanks! Sorry for the delay.

The easiest way to run the CI pipeline is either on github (next time it will run automatically for you since you will have a commit in the history when I have merged this), or you can use act to run them locally.

@m-dahl m-dahl merged commit 05d2c19 into sequenceplanner:master Jun 18, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants