-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: enable support for capmox #302
Conversation
Still need to add tests and waiting for a new release of ccm to get rid of the replace in go.mod |
I thing the PR is ready for review now. Please let me know if there is something wrong/missing |
Hi, everything looks good to me, but I’m unsure why the GitHub Actions didn’t run the tests. Could you please try rebasing or force-pushing your changes? Thanks. |
Everything seems to be up to date:
TBH I have no idea what to do here. |
This makes ccm compatible with cluster api and cluster api provider proxmox (capmox) Signed-off-by: Matthias Teich <[email protected]> Signed-off-by: Serge Logvinov <[email protected]>
Thank you! 👍 |
Great, thanks for your support! |
@Mattes83 I did refactoring of capmox mode, can you check the edge version please, i am going to make a new release soon. Thanks. |
Sorry for the late reply, i will try to find time to test it this week |
Sorry, i was ill the last days. I tested the current version in the main branch and it works flawlessly with CAPI |
Thank you! |
This is a follow up to sergelogvinov/proxmox-cloud-controller-manager#166
It will fail
Pull Request
What? (description)
This PR aims to add support for clusters managed by cluster api and the capmox infrastructure provider.
Why? (reasoning)
See discussion in This makes ccm compatible with cluster api and cluster api provider proxmox (capmox)
Acceptance
Please use the following checklist:
make conformance
)make lint
)make unit
)