Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: enable support for capmox #302

Merged
merged 1 commit into from
Jan 16, 2025
Merged

Conversation

Mattes83
Copy link
Contributor

@Mattes83 Mattes83 commented Jan 7, 2025

This is a follow up to sergelogvinov/proxmox-cloud-controller-manager#166
It will fail

Pull Request

What? (description)

This PR aims to add support for clusters managed by cluster api and the capmox infrastructure provider.

Why? (reasoning)

See discussion in This makes ccm compatible with cluster api and cluster api provider proxmox (capmox)

Acceptance

Please use the following checklist:

  • you linked an issue (if applicable)
  • you included tests (if applicable)
  • you ran conformance (make conformance)
  • you linted your code (make lint)
  • you linted your code (make unit)

See make help for a description of the available targets.

@Mattes83
Copy link
Contributor Author

Mattes83 commented Jan 8, 2025

Still need to add tests and waiting for a new release of ccm to get rid of the replace in go.mod

@Mattes83 Mattes83 marked this pull request as ready for review January 13, 2025 08:09
@Mattes83
Copy link
Contributor Author

I thing the PR is ready for review now. Please let me know if there is something wrong/missing

@sergelogvinov
Copy link
Owner

Hi, everything looks good to me, but I’m unsure why the GitHub Actions didn’t run the tests.

Could you please try rebasing or force-pushing your changes? Thanks.

@Mattes83
Copy link
Contributor Author

Everything seems to be up to date:
proxmox-csi-plugin git:(capmox) git remote add upstream [email protected]:sergelogvinov/proxmox-csi-plugin.git
➜ proxmox-csi-plugin git:(capmox) git fetch upstream
From github.com:sergelogvinov/proxmox-csi-plugin

  • [new branch] external-health -> upstream/external-health
  • [new branch] main -> upstream/main
    ➜ proxmox-csi-plugin git:(capmox) git rebase upstream/main
    Current branch capmox is up to date.
    ➜ proxmox-csi-plugin git:(capmox) git push origin capmox --force-with-lease
    Everything up-to-date
    ➜ proxmox-csi-plugin git:(capmox) git branch --show-current
    capmox

TBH I have no idea what to do here.

This makes ccm compatible with cluster api and cluster api provider proxmox (capmox)

Signed-off-by: Matthias Teich <[email protected]>
Signed-off-by: Serge Logvinov <[email protected]>
@sergelogvinov sergelogvinov merged commit 6145c7d into sergelogvinov:main Jan 16, 2025
5 checks passed
@sergelogvinov
Copy link
Owner

Thank you! 👍

@Mattes83 Mattes83 deleted the capmox branch January 20, 2025 06:40
@Mattes83 Mattes83 restored the capmox branch January 20, 2025 06:41
@Mattes83 Mattes83 deleted the capmox branch January 20, 2025 06:41
@Mattes83
Copy link
Contributor Author

Great, thanks for your support!
Are there any plans to release a new version of the proxmox-csi-plugin anytime soon? Then I could get rid of my custom built image.

@sergelogvinov
Copy link
Owner

@Mattes83 I did refactoring of capmox mode, can you check the edge version please, i am going to make a new release soon.

Thanks.

@Mattes83
Copy link
Contributor Author

Sorry for the late reply, i will try to find time to test it this week

@Mattes83
Copy link
Contributor Author

Mattes83 commented Feb 6, 2025

Sorry, i was ill the last days. I tested the current version in the main branch and it works flawlessly with CAPI

@sergelogvinov
Copy link
Owner

Sorry, i was ill the last days. I tested the current version in the main branch and it works flawlessly with CAPI

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants