Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A lot of things xD #13

Closed
wants to merge 2 commits into from
Closed

A lot of things xD #13

wants to merge 2 commits into from

Conversation

alpheratz0
Copy link

Modificaciones (supongo que hablas espanol)

  • Puse todo en un archivo unico (separe todo en funciones y volvi a escribi bastantes cosas)
  • Ahora acepta opciones (por ejemplo para mostar en espanol: tree.sh --language es)
  • Cree carpeta con lenguajes (los que ya estaban, espanol e ingles)
  • Ahora es mas facil agregar otros lenguajes
  • Le agregue un gif al readme para que se pueda ver el resultado

Espero lo puedas mergear, saludos!!!

@SuperQ
Copy link

SuperQ commented Dec 25, 2021

Nice rewrite. Maybe you want to pick my translation method in #14 in order to avoid having to spit the translations out.

@alpheratz0
Copy link
Author

@SuperQ

I'm not the owner of this repo and as you may see pull requests arent being reviewed by his owner :(

Nice rewrite. Maybe you want to pick my translation method in #14 in order to avoid having to spit the translations out.

I prefer to keep translation messages in separate files, just imagine if in some months support for 20 languages is added, that would be 200+ lines of code in the tree.sh file, that sounds messy, in the other hand if you only need a few languages supported I think it wouldnt matter at all to move all translations to the tree.sh file.

Keep up the good work!

@SuperQ
Copy link

SuperQ commented Dec 27, 2021

The problem with splitting it out is you need to download all the files, rather than just the one script. It also makes it messy to use because if you wanted to package it for deb/rpm, it now requires modifications to support putting the translations in a different location from the script (/usr/bin/ vs /usr/lib/).

@alpheratz0
Copy link
Author

The problem with splitting it out is you need to download all the files, rather than just the one script. It also makes it messy to use because if you wanted to package it for deb/rpm, it now requires modifications to support putting the translations in a different location from the script (/usr/bin/ vs /usr/lib/).

That's a good point, done!
https://github.com/alpheratz0/tree.sh

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants