Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

{cryptoQuotes} v1.3.2 🚀 #40

Merged
merged 29 commits into from
Nov 7, 2024
Merged

{cryptoQuotes} v1.3.2 🚀 #40

merged 29 commits into from
Nov 7, 2024

Commits on Jun 14, 2024

  1. Expanded Exchange Support [See #14] (#15)

    The following exchanges have been addded
    
    * crypto.com (spot, futures, fundingrate)
    * huobi (spot, futures)
    * MEXC (spot, futures, fundingrate)
    
    Minor changes
    
    get_quote()-function needed small changes in order to return the data in OHLC-V format
    due to Huobi API specifics.
    
    NOTE:
    crypto.com US compliant and can therefore run on US resident computers without VPN.
    Huobi API documentation is huge - this still needs work, and confirmation on what it can return
    other than what is provided already. The funding rate for cryto.com is hourly, as opposed to 4 hour and 8 hours for Binance and bybit.
    
    All devtool::check() have passed locally.
    
    Footnote:
    
    {cryptoQuotes} is not going to be updated for a long while - unless there is any serious bugs,
    or any submission considerations.
    serkor1 authored Jun 14, 2024
    Configuration menu
    Copy the full SHA
    1426fb5 View commit details
    Browse the repository at this point in the history
  2. Expanded Exchange Support [See #14]

    The following exchanges have been addded
    
    * crypto.com (spot, futures, fundingrate)
    * huobi (spot, futures)
    * MEXC (spot, futures, fundingrate)
    
    Minor changes
    
    get_quote()-function needed small changes in order to return the data in OHLC-V format
    due to Huobi API specifics.
    
    NOTE:
    crypto.com US compliant and can therefore run on US resident computers without VPN.
    Huobi API documentation is huge - this still needs work, and confirmation on what it can return
    other than what is provided already. The funding rate for cryto.com is hourly, as opposed to 4 hour and 8 hours for Binance and bybit.
    
    All devtool::check() have passed locally.
    
    Footnote:
    
    {cryptoQuotes} is not going to be updated for a long while - unless there is any serious bugs,
    or any submission considerations.
    serkor1 committed Jun 14, 2024
    Configuration menu
    Copy the full SHA
    037d7db View commit details
    Browse the repository at this point in the history
  3. Fixed error in 037d7db

    Forgot `git add` on important changes pre `push` and `merge` - These errors wont
    get caught via Github Actions because they are skipped on CI/CD.
    
    Lesson: Don't code while drunk. Or don't forget the full check after each change, even though it works in the sandbox.
    serkor1 committed Jun 14, 2024
    Configuration menu
    Copy the full SHA
    a1fcb3b View commit details
    Browse the repository at this point in the history

Commits on Jun 28, 2024

  1. Chart updates ❤️ (#22)

    * Fixed Bugs and Updated Tests
    
    This commit closes #13 🚀
    
    Additional Fix:
    
    The random sampling of tickers in the kraken-tests forced the failure of the tests. A seed of 1903 has been added to each unit test.
    
    Added test indicators on the get_quote unit tests as it would fail for Bitmart in the 1h. This is due to a rounding error; this requires further investigation at a later point.
    
    The chart unittests has been updated to make sure it runs without any conditions at all to avoid the same errors as in #13.
    
    Note:
    
    All checks have passed locally, and NEWS.md has been updated accordingly
    
    * Chart layout changes 🚀
    
    The chart now has a higher top-margin to prevent modebar from overlaying the title and subtitle.
    
    The modebar now includes drawrect, drawline and eraseshape to create and remove support and resistance lines.
    
    The chart title and subtitle can also be customized interactively. See Discussion #19
    
    All charts are now exported in 4k as .svg-files.
    
    The modebar is always visible by default, but can be removed within the options.
    
    The charts now has custom color-palettes via hcl.pals()
    
    Known Issues:
    
    The exported charts has really small font sizes, so it is barely visible.
    
    * Update Chart Options 😍
    
    The chart-function now has the following options:
    
    * scale: scales the font-size.
    * static: a logical value FALSE by default. If TRUE it act as a regular static plot a la ggplot.
    
    The chart function now asserts the size being between 0 and 1, and checks for valid hcl.palettes with ignore.case set to TRUE.
    
    All subcharts have had annotations multiplied by args from the chart funciton.
    
    NOTE: All checks have passed locally 🚀
    serkor1 authored Jun 28, 2024
    Configuration menu
    Copy the full SHA
    86ae664 View commit details
    Browse the repository at this point in the history
  2. {pkgdown}-fix 🔧

    Package name has to be followed by version.
    serkor1 committed Jun 28, 2024
    Configuration menu
    Copy the full SHA
    2795667 View commit details
    Browse the repository at this point in the history

Commits on Jun 29, 2024

  1. Updated and reworked documentation (#23)

    * Updated Documentation 📚
    
    * All pkg have been changed to {pkg}.
    * Description of {pkgdown} changed to be more SEO friendly.
    * Fancy-pants blockquotes created.
    
    * Updated {pkgdown} and NEWS.md 🚀
    
    The documentation on {pkgdown} has been rewritten to remove various {tidyverse} related bugs and to align the website to the new {pkg} syntax.
    serkor1 authored Jun 29, 2024
    Configuration menu
    Copy the full SHA
    4e3870c View commit details
    Browse the repository at this point in the history
  2. 🔥 Expanding Unit Testing and Minor Bug-fixes 🔥

    The code coverage now covers all exchanges that can be run in the US. A minor bug-fix on Huobi FUTURES have been fixed in the process.
    serkor1 authored Jun 29, 2024
    Configuration menu
    Copy the full SHA
    95ec42c View commit details
    Browse the repository at this point in the history

Commits on Jul 1, 2024

  1. Test expansion and (more) bug-fixes 🔧 🔥 (#27)

    * Expanded Test and bug-fix 🔥 🔥
    
    The code coverage now covers all exchanges that can be run in the US. A minor bug-fix on Huobi FUTURES have been fixed in the process.
    
    * Bug-fixes and Test-Expansion  🔧
    
    The test-getQuote.R has been expanded to include ALL intervals. The get_quote()-function
    has been wrapped in try() as testthat doesn't capture the error per se.
    
    Various bugs have been captured in this process:
    
    1. Binance Futures doesn't have a 1s interval.
    2. Bitmart doesn't have a 3m, 6h or 3d interval. However, the
    documentation clearly states that it has. The URLs have been pasted directly
    into the browser to verify this - its a but on their side.
    
    Note:
    
    This commit closes #26
    serkor1 authored Jul 1, 2024
    Configuration menu
    Copy the full SHA
    697bbb0 View commit details
    Browse the repository at this point in the history
  2. Fixed unittest error 🔧

    This error occurs for tickers that were listed recently, and therefore doesn't have daily data yet. The random sampling of tickers have to change.
    serkor1 committed Jul 1, 2024
    Configuration menu
    Copy the full SHA
    fddaeb8 View commit details
    Browse the repository at this point in the history

Commits on Jul 7, 2024

  1. Rebranding, efficiency and end-user upgrades 🚀 🚀 (#28)

    * Filter power-up 🔼 🔼
    
    All get_*-family of function are usings stats::window() instead of {xts}-syntax. Local tests shows that {stats} is faster. About 5-10 times faster.
    
    Bug-fix:
    
    If interval were incorrectly specificed the error-message werent rendering properly. This were due to a missing quotation-mark.
    
    * Binance, Assertand Fetch Power-Ups ⬆️ ⬆️
    
    Assert:
    
    The assert function has been reworked so it only evaluates all statements if any of the values are FALSE. The update is twice as fast as before in cases where all statements are TRUE.
    
    Fetch:
    
    The fetch()-function is now less defensive and uses only a single try-catch statement.
    
    GET:
    
    The GET()-function is now less defensive
    
    Binance:
    
    All possible parameters have been vectorized and/or simplified where possible.
    
    General:
    
    All ifelse()-functions have been replaced with if () else as these are faster.
    For cases where more than two if statements are needed, a switch-function is used instead (with default values)
    
    * ByBit Power-Ups ⬆️ ⬆️
    
    The ByBit API has been upgraded to reduce overhead on if-statements and
    interval look-up times.
    
    See commit 8373bee for more details if there is any interest.
    
    > [!NOTE]
    >
    > All tests have passed locally.
    
    * Bitmart Power-Ups ⬆️ ⬆️
    
    The Bitmart API has been upgraded to reduce overhead on if-statements and
    interval look-up times.
    
    See commit 8373bee for more details if there is any interest.
    
    > [!NOTE]
    >
    > All tests have passed locally.
    
    * Crypto.com Power-Ups ⬆️ ⬆️
    
    The Crypto.com API has been upgraded to reduce overhead on if-statements and
    interval look-up times.
    
    See commit 8373bee for more details if there is any interest.
    
    > [!NOTE]
    >
    > All tests have passed locally.
    
    * MEXC Power-Ups + Bugfix ⬆️ ⬆️
    
    MEXC API have been reworked and vectorized. See commit 8373bee
    for more infor.
    
    Bugfix 🔧
    
    There was a small bug in the SPOT market where values to dates would
    be passed as scientific values.
    
    * Kraken Power-Ups ⬆️ ⬆️
    
    Kraken API have been reworked and vectorized. See commit 8373bee for more information.
    
    > [!NOTE]
    >
    > All tests have passed locally.
    
    * KuCoin Power-Ups ⬆️ ⬆️
    
    MEXC API have been reworked and vectorized. See commit 8373bee
    for more information.
    
    Possible bug has been fixed 🔧 (See commit 5a02a40, its similar)
    
    * Huobi (HTX) Power-Ups ⬆️ ⬆️
    
    Huobi API have been reworked and vectorized. See commit 5a02a40
    for more information.
    
    > [!NOTE]
    >
    > All tests have passed locally.
    
    * Endpoint Power-Ups ⬆️ ⬆️
    
    The available_*-family of functions have been reworked (slightly) and has really minor performance gain. At this stage there is no room for improvement on the coding side - however there are places where redundant codes could be removed, but they act as a defensive measure. These will be addressed at a way later stage.
    
    * {cryptoQuotes} Power-Ups  ⬆️ ⬆️
    
    New feature:
    ------------
    
    Reading and writing xts-objects using read.zoo and write.zoo under the hood.
    See the read_xts()- and write_xts()-functions for more details.
    
    Added unit tests and updated NEWS.md
    
    This function is dedicated to @gokberkcan7 🔥
    
    * Updated README ⬆️ ⬆️
    
    The README.md now uses data.table for the most part - all checks passes despite not being imported.
    The exchanges have been recoded, and the available endpoints are being updated dynamically.
    
    * Updated description and version bump ⬆️ ⬆️
    
    The package has a more suitable title and description to reflect it's actual purpose and usecase.
    
    * Removed redundant operators ⬆️
    
    These include, but are not limited to, c(1) and c(foo). In cases like these the values ahve been chaged to 1 and foo.
    
    Minor typos and such have been fixed in the README.me
    
    * Updated vignette ⬆️ ⬆️
    
    The custom chart vignette is now more user-friendly. It was targeted developers before
    serkor1 committed Jul 7, 2024
    Configuration menu
    Copy the full SHA
    c15173a View commit details
    Browse the repository at this point in the history

Commits on Jul 9, 2024

  1. {pkgdown}-update ⬆️ (#29)

    {pkgdown} has been updated. During the update a few minor changes have been implemented to the documentation.
    
    1. frontpage has been reworked
    2. theme has been changed to default (the update seems to have broken the original setup)
    3. alt text has been added to article 5
    
    Note: At some point the alt text has to be reworked completely.
    serkor1 authored Jul 9, 2024
    Configuration menu
    Copy the full SHA
    e08df82 View commit details
    Browse the repository at this point in the history

Commits on Aug 16, 2024

  1. Accessibility upgrade of chart()-function (#31)

    * Accessibility upgrade of chart()-function
    
    * The chart()-function now has a new option  which controls the overall width of the chart.
    
    NEWS has been updated
    
    * MEXC Bugfix 🔧
    
    PR #31 failed the checks. The source of the error:
    
    * MEXC has changed the response-object on available tickers. This has been fixed.
    
    All checks have passed.
    serkor1 authored Aug 16, 2024
    Configuration menu
    Copy the full SHA
    31923a1 View commit details
    Browse the repository at this point in the history

Commits on Sep 19, 2024

  1. 📚 Update custom_indicators.Rmd (#32)

    * Update custom_indicators.Rmd
    
    The duplicated x-axis have been removed from the custom indicators in the Vignette.
    
    * Update custom_indicators.Rmd
    
    * Removed `dplyr`
    * Removed whitespace
    * added namespaced qualified `layout`-call
    
    ---------
    Co-authored-by: Serkan Korkmaz <[email protected]>
    stavralf authored Sep 19, 2024
    Configuration menu
    Copy the full SHA
    7207205 View commit details
    Browse the repository at this point in the history

Commits on Oct 3, 2024

  1. Fix 7207205 🔨

    In the excellent PR #32 by @stavralf, I made a small error during the review, which have now been fixed.
    serkor1 committed Oct 3, 2024
    Configuration menu
    Copy the full SHA
    b920c7d View commit details
    Browse the repository at this point in the history

Commits on Nov 1, 2024

  1. BitMart update 🔥 (#38)

    The BitMart exchange have updated their futures API to V2. V1 will stop
    working 11/30/2024.
    serkor1 authored Nov 1, 2024
    Configuration menu
    Copy the full SHA
    d86f32e View commit details
    Browse the repository at this point in the history
  2. BitMart update 🔥 (#38)

    The BitMart exchange have updated their futures API to V2. V1 will stop
    working 11/30/2024.
    
    * Updated workflow file.
    * Updated NEWS.md
    serkor1 committed Nov 1, 2024
    Configuration menu
    Copy the full SHA
    c3b2a0f View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    1d717fc View commit details
    Browse the repository at this point in the history

Commits on Nov 2, 2024

  1. Kraken tickers updated 🔥

    * The Kraken API responds to tickers not returned by `available_tickers()` (See #37).
    * Fix 🔨: Prior to version 1.3.2 the returned tickers were based on the array names from Kraken; this has been changed to altnames which is also more simple.
    
    Thank you @Opt33 for reporting the issue.
    serkor1 committed Nov 2, 2024
    Configuration menu
    Copy the full SHA
    e718cd0 View commit details
    Browse the repository at this point in the history
  2. Fear and Greed Index Fix 🔨

    * The `get_fgi()`-function returned 199 observations when no arguments were passed. Explicitly passed a `length`-argument to mitigate this.
    serkor1 committed Nov 2, 2024
    Configuration menu
    Copy the full SHA
    052f949 View commit details
    Browse the repository at this point in the history
  3. Updated unit-test 🔨

    * The unit-test for `infer_interval()` fails around daylight saving times. This has been fixed by increasing the
    number of observations from 2 to 200.
    serkor1 committed Nov 2, 2024
    Configuration menu
    Copy the full SHA
    ca612b9 View commit details
    Browse the repository at this point in the history
  4. Removed /playground and cryptoQuotes.Rproj 👋

    * /playground interferes with the git-history
    * cryptoQuotes.Rproj is an artefact of RStudio. This project have moved to Positron for the development.
    serkor1 committed Nov 2, 2024
    Configuration menu
    Copy the full SHA
    05c4157 View commit details
    Browse the repository at this point in the history
  5. Removed .html-file in root directory and updated .gitignore 🔨

    * Positron uses rmarkdown::render() and it requires time to adapt to this. So redundant files
    will start to flow and get removed as we go.
    serkor1 committed Nov 2, 2024
    Configuration menu
    Copy the full SHA
    7e11545 View commit details
    Browse the repository at this point in the history
  6. Updated DESCRIPTION and codemeta.json 🔨

    * Moved to Roxygen 7.3.2
    * Updaed codemeta.json
    serkor1 committed Nov 2, 2024
    Configuration menu
    Copy the full SHA
    475e3f8 View commit details
    Browse the repository at this point in the history
  7. Prepare release for version 1.3.2 🔥

    * See Issue #39
    serkor1 committed Nov 2, 2024
    Configuration menu
    Copy the full SHA
    f7326ef View commit details
    Browse the repository at this point in the history

Commits on Nov 6, 2024

  1. Updated Documentation 📚

    * Added pkg-anchors (were missing, and CRAN checks did not pass)
    serkor1 committed Nov 6, 2024
    Configuration menu
    Copy the full SHA
    a539695 View commit details
    Browse the repository at this point in the history

Commits on Nov 7, 2024

  1. Fixed Unit-test for store_xts() 🔧 and updated documentation 📚

    * The function were throwing an error:
    
    Found the following files/directories:
      ‘Rtmpx3Ay8DBTC.csv’
    
    Added `unlink()` to the end of the test, which fixes everything locally 🔥
    serkor1 committed Nov 7, 2024
    Configuration menu
    Copy the full SHA
    e129732 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    85f3366 View commit details
    Browse the repository at this point in the history
  3. Fixed Description 🔧

    * All references to other packages should be single quoted - get rekt otherwise...
    serkor1 committed Nov 7, 2024
    Configuration menu
    Copy the full SHA
    1347b10 View commit details
    Browse the repository at this point in the history
  4. Updated crancomments ❤️

    serkor1 committed Nov 7, 2024
    Configuration menu
    Copy the full SHA
    924a5ab View commit details
    Browse the repository at this point in the history