-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
{cryptoQuotes} v1.3.2 🚀 #40
Commits on Jun 14, 2024
-
Expanded Exchange Support [See #14] (#15)
The following exchanges have been addded * crypto.com (spot, futures, fundingrate) * huobi (spot, futures) * MEXC (spot, futures, fundingrate) Minor changes get_quote()-function needed small changes in order to return the data in OHLC-V format due to Huobi API specifics. NOTE: crypto.com US compliant and can therefore run on US resident computers without VPN. Huobi API documentation is huge - this still needs work, and confirmation on what it can return other than what is provided already. The funding rate for cryto.com is hourly, as opposed to 4 hour and 8 hours for Binance and bybit. All devtool::check() have passed locally. Footnote: {cryptoQuotes} is not going to be updated for a long while - unless there is any serious bugs, or any submission considerations.
Configuration menu - View commit details
-
Copy full SHA for 1426fb5 - Browse repository at this point
Copy the full SHA 1426fb5View commit details -
Expanded Exchange Support [See #14]
The following exchanges have been addded * crypto.com (spot, futures, fundingrate) * huobi (spot, futures) * MEXC (spot, futures, fundingrate) Minor changes get_quote()-function needed small changes in order to return the data in OHLC-V format due to Huobi API specifics. NOTE: crypto.com US compliant and can therefore run on US resident computers without VPN. Huobi API documentation is huge - this still needs work, and confirmation on what it can return other than what is provided already. The funding rate for cryto.com is hourly, as opposed to 4 hour and 8 hours for Binance and bybit. All devtool::check() have passed locally. Footnote: {cryptoQuotes} is not going to be updated for a long while - unless there is any serious bugs, or any submission considerations.
Configuration menu - View commit details
-
Copy full SHA for 037d7db - Browse repository at this point
Copy the full SHA 037d7dbView commit details -
Forgot `git add` on important changes pre `push` and `merge` - These errors wont get caught via Github Actions because they are skipped on CI/CD. Lesson: Don't code while drunk. Or don't forget the full check after each change, even though it works in the sandbox.
Configuration menu - View commit details
-
Copy full SHA for a1fcb3b - Browse repository at this point
Copy the full SHA a1fcb3bView commit details
Commits on Jun 28, 2024
-
* Fixed Bugs and Updated Tests This commit closes #13 🚀 Additional Fix: The random sampling of tickers in the kraken-tests forced the failure of the tests. A seed of 1903 has been added to each unit test. Added test indicators on the get_quote unit tests as it would fail for Bitmart in the 1h. This is due to a rounding error; this requires further investigation at a later point. The chart unittests has been updated to make sure it runs without any conditions at all to avoid the same errors as in #13. Note: All checks have passed locally, and NEWS.md has been updated accordingly * Chart layout changes 🚀 The chart now has a higher top-margin to prevent modebar from overlaying the title and subtitle. The modebar now includes drawrect, drawline and eraseshape to create and remove support and resistance lines. The chart title and subtitle can also be customized interactively. See Discussion #19 All charts are now exported in 4k as .svg-files. The modebar is always visible by default, but can be removed within the options. The charts now has custom color-palettes via hcl.pals() Known Issues: The exported charts has really small font sizes, so it is barely visible. * Update Chart Options 😍 The chart-function now has the following options: * scale: scales the font-size. * static: a logical value FALSE by default. If TRUE it act as a regular static plot a la ggplot. The chart function now asserts the size being between 0 and 1, and checks for valid hcl.palettes with ignore.case set to TRUE. All subcharts have had annotations multiplied by args from the chart funciton. NOTE: All checks have passed locally 🚀
Configuration menu - View commit details
-
Copy full SHA for 86ae664 - Browse repository at this point
Copy the full SHA 86ae664View commit details -
Configuration menu - View commit details
-
Copy full SHA for 2795667 - Browse repository at this point
Copy the full SHA 2795667View commit details
Commits on Jun 29, 2024
-
Updated and reworked documentation (#23)
* Updated Documentation 📚 * All pkg have been changed to {pkg}. * Description of {pkgdown} changed to be more SEO friendly. * Fancy-pants blockquotes created. * Updated {pkgdown} and NEWS.md 🚀 The documentation on {pkgdown} has been rewritten to remove various {tidyverse} related bugs and to align the website to the new {pkg} syntax.
Configuration menu - View commit details
-
Copy full SHA for 4e3870c - Browse repository at this point
Copy the full SHA 4e3870cView commit details -
🔥 Expanding Unit Testing and Minor Bug-fixes 🔥
The code coverage now covers all exchanges that can be run in the US. A minor bug-fix on Huobi FUTURES have been fixed in the process.
Configuration menu - View commit details
-
Copy full SHA for 95ec42c - Browse repository at this point
Copy the full SHA 95ec42cView commit details
Commits on Jul 1, 2024
-
Test expansion and (more) bug-fixes 🔧 🔥 (#27)
* Expanded Test and bug-fix 🔥 🔥 The code coverage now covers all exchanges that can be run in the US. A minor bug-fix on Huobi FUTURES have been fixed in the process. * Bug-fixes and Test-Expansion 🔧 The test-getQuote.R has been expanded to include ALL intervals. The get_quote()-function has been wrapped in try() as testthat doesn't capture the error per se. Various bugs have been captured in this process: 1. Binance Futures doesn't have a 1s interval. 2. Bitmart doesn't have a 3m, 6h or 3d interval. However, the documentation clearly states that it has. The URLs have been pasted directly into the browser to verify this - its a but on their side. Note: This commit closes #26
Configuration menu - View commit details
-
Copy full SHA for 697bbb0 - Browse repository at this point
Copy the full SHA 697bbb0View commit details -
This error occurs for tickers that were listed recently, and therefore doesn't have daily data yet. The random sampling of tickers have to change.
Configuration menu - View commit details
-
Copy full SHA for fddaeb8 - Browse repository at this point
Copy the full SHA fddaeb8View commit details
Commits on Jul 7, 2024
-
Rebranding, efficiency and end-user upgrades 🚀 🚀 (#28)
* Filter power-up 🔼 🔼 All get_*-family of function are usings stats::window() instead of {xts}-syntax. Local tests shows that {stats} is faster. About 5-10 times faster. Bug-fix: If interval were incorrectly specificed the error-message werent rendering properly. This were due to a missing quotation-mark. * Binance, Assertand Fetch Power-Ups ⬆️ ⬆️ Assert: The assert function has been reworked so it only evaluates all statements if any of the values are FALSE. The update is twice as fast as before in cases where all statements are TRUE. Fetch: The fetch()-function is now less defensive and uses only a single try-catch statement. GET: The GET()-function is now less defensive Binance: All possible parameters have been vectorized and/or simplified where possible. General: All ifelse()-functions have been replaced with if () else as these are faster. For cases where more than two if statements are needed, a switch-function is used instead (with default values) * ByBit Power-Ups ⬆️ ⬆️ The ByBit API has been upgraded to reduce overhead on if-statements and interval look-up times. See commit 8373bee for more details if there is any interest. > [!NOTE] > > All tests have passed locally. * Bitmart Power-Ups ⬆️ ⬆️ The Bitmart API has been upgraded to reduce overhead on if-statements and interval look-up times. See commit 8373bee for more details if there is any interest. > [!NOTE] > > All tests have passed locally. * Crypto.com Power-Ups ⬆️ ⬆️ The Crypto.com API has been upgraded to reduce overhead on if-statements and interval look-up times. See commit 8373bee for more details if there is any interest. > [!NOTE] > > All tests have passed locally. * MEXC Power-Ups + Bugfix ⬆️ ⬆️ MEXC API have been reworked and vectorized. See commit 8373bee for more infor. Bugfix 🔧 There was a small bug in the SPOT market where values to dates would be passed as scientific values. * Kraken Power-Ups ⬆️ ⬆️ Kraken API have been reworked and vectorized. See commit 8373bee for more information. > [!NOTE] > > All tests have passed locally. * KuCoin Power-Ups ⬆️ ⬆️ MEXC API have been reworked and vectorized. See commit 8373bee for more information. Possible bug has been fixed 🔧 (See commit 5a02a40, its similar) * Huobi (HTX) Power-Ups ⬆️ ⬆️ Huobi API have been reworked and vectorized. See commit 5a02a40 for more information. > [!NOTE] > > All tests have passed locally. * Endpoint Power-Ups ⬆️ ⬆️ The available_*-family of functions have been reworked (slightly) and has really minor performance gain. At this stage there is no room for improvement on the coding side - however there are places where redundant codes could be removed, but they act as a defensive measure. These will be addressed at a way later stage. * {cryptoQuotes} Power-Ups ⬆️ ⬆️ New feature: ------------ Reading and writing xts-objects using read.zoo and write.zoo under the hood. See the read_xts()- and write_xts()-functions for more details. Added unit tests and updated NEWS.md This function is dedicated to @gokberkcan7 🔥 * Updated README ⬆️ ⬆️ The README.md now uses data.table for the most part - all checks passes despite not being imported. The exchanges have been recoded, and the available endpoints are being updated dynamically. * Updated description and version bump ⬆️ ⬆️ The package has a more suitable title and description to reflect it's actual purpose and usecase. * Removed redundant operators ⬆️ These include, but are not limited to, c(1) and c(foo). In cases like these the values ahve been chaged to 1 and foo. Minor typos and such have been fixed in the README.me * Updated vignette ⬆️ ⬆️ The custom chart vignette is now more user-friendly. It was targeted developers before
Configuration menu - View commit details
-
Copy full SHA for c15173a - Browse repository at this point
Copy the full SHA c15173aView commit details
Commits on Jul 9, 2024
-
{pkgdown} has been updated. During the update a few minor changes have been implemented to the documentation. 1. frontpage has been reworked 2. theme has been changed to default (the update seems to have broken the original setup) 3. alt text has been added to article 5 Note: At some point the alt text has to be reworked completely.
Configuration menu - View commit details
-
Copy full SHA for e08df82 - Browse repository at this point
Copy the full SHA e08df82View commit details
Commits on Aug 16, 2024
-
Accessibility upgrade of chart()-function (#31)
* Accessibility upgrade of chart()-function * The chart()-function now has a new option which controls the overall width of the chart. NEWS has been updated * MEXC Bugfix 🔧 PR #31 failed the checks. The source of the error: * MEXC has changed the response-object on available tickers. This has been fixed. All checks have passed.
Configuration menu - View commit details
-
Copy full SHA for 31923a1 - Browse repository at this point
Copy the full SHA 31923a1View commit details
Commits on Sep 19, 2024
-
📚 Update custom_indicators.Rmd (#32)
* Update custom_indicators.Rmd The duplicated x-axis have been removed from the custom indicators in the Vignette. * Update custom_indicators.Rmd * Removed `dplyr` * Removed whitespace * added namespaced qualified `layout`-call --------- Co-authored-by: Serkan Korkmaz <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 7207205 - Browse repository at this point
Copy the full SHA 7207205View commit details
Commits on Oct 3, 2024
-
Configuration menu - View commit details
-
Copy full SHA for b920c7d - Browse repository at this point
Copy the full SHA b920c7dView commit details
Commits on Nov 1, 2024
-
The BitMart exchange have updated their futures API to V2. V1 will stop working 11/30/2024.
Configuration menu - View commit details
-
Copy full SHA for d86f32e - Browse repository at this point
Copy the full SHA d86f32eView commit details -
The BitMart exchange have updated their futures API to V2. V1 will stop working 11/30/2024. * Updated workflow file. * Updated NEWS.md
Configuration menu - View commit details
-
Copy full SHA for c3b2a0f - Browse repository at this point
Copy the full SHA c3b2a0fView commit details -
Merge branch 'development' of https://github.com/serkor1/cryptoQuotes …
…into development
Configuration menu - View commit details
-
Copy full SHA for 1d717fc - Browse repository at this point
Copy the full SHA 1d717fcView commit details
Commits on Nov 2, 2024
-
Configuration menu - View commit details
-
Copy full SHA for e718cd0 - Browse repository at this point
Copy the full SHA e718cd0View commit details -
* The `get_fgi()`-function returned 199 observations when no arguments were passed. Explicitly passed a `length`-argument to mitigate this.
Configuration menu - View commit details
-
Copy full SHA for 052f949 - Browse repository at this point
Copy the full SHA 052f949View commit details -
* The unit-test for `infer_interval()` fails around daylight saving times. This has been fixed by increasing the number of observations from 2 to 200.
Configuration menu - View commit details
-
Copy full SHA for ca612b9 - Browse repository at this point
Copy the full SHA ca612b9View commit details -
Removed /playground and cryptoQuotes.Rproj 👋
* /playground interferes with the git-history * cryptoQuotes.Rproj is an artefact of RStudio. This project have moved to Positron for the development.
Configuration menu - View commit details
-
Copy full SHA for 05c4157 - Browse repository at this point
Copy the full SHA 05c4157View commit details -
Removed .html-file in root directory and updated .gitignore 🔨
* Positron uses rmarkdown::render() and it requires time to adapt to this. So redundant files will start to flow and get removed as we go.
Configuration menu - View commit details
-
Copy full SHA for 7e11545 - Browse repository at this point
Copy the full SHA 7e11545View commit details -
Updated DESCRIPTION and codemeta.json 🔨
* Moved to Roxygen 7.3.2 * Updaed codemeta.json
Configuration menu - View commit details
-
Copy full SHA for 475e3f8 - Browse repository at this point
Copy the full SHA 475e3f8View commit details -
Configuration menu - View commit details
-
Copy full SHA for f7326ef - Browse repository at this point
Copy the full SHA f7326efView commit details
Commits on Nov 6, 2024
-
* Added pkg-anchors (were missing, and CRAN checks did not pass)
Configuration menu - View commit details
-
Copy full SHA for a539695 - Browse repository at this point
Copy the full SHA a539695View commit details
Commits on Nov 7, 2024
-
Fixed Unit-test for
store_xts()
🔧 and updated documentation 📚* The function were throwing an error: Found the following files/directories: ‘Rtmpx3Ay8DBTC.csv’ Added `unlink()` to the end of the test, which fixes everything locally 🔥
Configuration menu - View commit details
-
Copy full SHA for e129732 - Browse repository at this point
Copy the full SHA e129732View commit details -
Configuration menu - View commit details
-
Copy full SHA for 85f3366 - Browse repository at this point
Copy the full SHA 85f3366View commit details -
* All references to other packages should be single quoted - get rekt otherwise...
Configuration menu - View commit details
-
Copy full SHA for 1347b10 - Browse repository at this point
Copy the full SHA 1347b10View commit details -
Configuration menu - View commit details
-
Copy full SHA for 924a5ab - Browse repository at this point
Copy the full SHA 924a5abView commit details