Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix an issue where inputstream is sometimes lost. #1678

Merged
merged 1 commit into from
Nov 29, 2024

Conversation

provenceee
Copy link
Collaborator

What type of PR is this?

Bug

What this PR does / why we need it?

fix an issue where inputstream is sometimes lost.

Which issue(s) this PR fixes?

Fixes #1646

Does this PR introduce a user-facing change?

No

Checklist

  • Make sure there is a GitHub_issue related with this PR before you start working on it.
  • Make sure you have squashed your change to one single commit.
  • GitHub Actions works fine in this PR.

@provenceee provenceee self-assigned this Nov 20, 2024
@provenceee provenceee added kind/bug Something isn't working area/plugin Issues or PRs releated to sermant plugin service labels Nov 20, 2024
Copy link

codecov bot commented Nov 20, 2024

Codecov Report

Attention: Patch coverage is 81.39535% with 8 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
...ring/interceptor/DispatcherServletInterceptor.java 61.53% 5 Missing ⚠️
...interceptor/AbstractHandlerMappingInterceptor.java 81.81% 1 Missing and 1 partial ⚠️
...sermant/router/spring/utils/SpringRouterUtils.java 88.88% 1 Missing ⚠️
Flag Coverage Δ Complexity Δ
unittests 43.97% <81.39%> (-0.05%) 181.00 <0.00> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ Complexity Δ
...rmant/loadbalancer/interceptor/UrlInterceptor.java 76.00% <ø> (ø) 0.00 <0.00> (ø)
...t/loadbalancer/declarer/ClientFactoryDeclarer.java 0.00% <ø> (ø) 0.00 <0.00> (ø)
...itor/interceptor/DispatcherServletInterceptor.java 0.00% <ø> (ø) 0.00 <0.00> (ø)
.../ServiceDiscoveryRegistryDirectoryInterceptor.java 75.00% <ø> (ø) 2.00 <0.00> (ø)
...ain/java/io/sermant/router/spring/entity/Keys.java 100.00% <100.00%> (ø) 0.00 <0.00> (?)
...sermant/router/spring/handler/AbstractHandler.java 35.71% <ø> (ø) 0.00 <0.00> (ø)
.../io/sermant/router/spring/handler/LaneHandler.java 89.47% <100.00%> (ø) 0.00 <0.00> (?)
...a/io/sermant/router/spring/handler/TagHandler.java 100.00% <100.00%> (ø) 0.00 <0.00> (?)
...sermant/router/spring/service/LaneServiceImpl.java 100.00% <ø> (ø) 0.00 <0.00> (ø)
...ava/io/sermant/router/spring/utils/RouteUtils.java 75.00% <ø> (+3.12%) 0.00 <0.00> (ø)
... and 3 more

lilai23
lilai23 previously approved these changes Nov 28, 2024
hanbingleixue
hanbingleixue previously approved these changes Nov 29, 2024
@Sherlockhan Sherlockhan merged commit ba0b5d0 into sermant-io:develop Nov 29, 2024
101 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/plugin Issues or PRs releated to sermant plugin service kind/bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Host interface httpServletRequest can not get inputStream when using router plugin
5 participants