Add the entity class for xDS flow control functionality #1679
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Flags with carried forward coverage won't be shown. Click here to find out more.
|
lilai23
changed the title
daizhenyu
reviewed
Nov 25, 2024
| /** | ||
| * Should the value be appended | ||
| */ | ||
| private boolean append; |
hanbingleixue
force-pushed
the
flowcontrol
branch
from
873b0cf
to
06dd506
Compare
lilai23
reviewed
Nov 26, 2024
Comment on lines
26
to
29
| /** | ||
| * the specified delay will be injected before a new request | ||
| */ | ||
| private long fixedDelay; |
There was a problem hiding this comment.
specify unit of fixedDelay, s or ms
lilai23
reviewed
Nov 26, 2024
Comment on lines
24
to
26
| */ | ||
| public class XdsFractionalPercent { | ||
| /** |
There was a problem hiding this comment.
Is there any relation with xDS for this entity？ If not, modify the name
lilai23
reviewed
Nov 26, 2024
| * The number of consecutive 5xx responses or local origin errors that are mapped to 5xx error codes before a | ||
| * consecutive 5xx ejection occurs | ||
| */ | ||
| private int consecutive5Xx; |
hanbingleixue
force-pushed
the
flowcontrol
branch
from
06dd506
to
eb492ed
Compare
Signed-off-by: hanbingleixue <[email protected]>
hanbingleixue
force-pushed
the
flowcontrol
branch
from
eb492ed
to
b72bc93
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Feature
What this PR does / why we need it?
Add the entity class for Xds flow control functionality
Which issue(s) this PR fixes？
Fixes #1515
Does this PR introduce a user-facing change?
No
Checklist