Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support input data on log scale #19

Merged
merged 3 commits into from
Oct 17, 2024
Merged

Support input data on log scale #19

merged 3 commits into from
Oct 17, 2024

Conversation

hillalex
Copy link
Member

@hillalex hillalex commented Oct 17, 2024

Allow user to pass data on a log scale. If the scale=log argument is passed to the model, don't transform the data before/after model fitting.

@hillalex hillalex marked this pull request as ready for review October 17, 2024 15:44
Copy link

codecov bot commented Oct 17, 2024

Codecov Report

Attention: Patch coverage is 93.33333% with 1 line in your changes missing coverage. Please review.

Project coverage is 92.48%. Comparing base (bc4da25) to head (3fe300a).
Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
R/biokinetics.R 92.85% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #19      +/-   ##
==========================================
- Coverage   92.60%   92.48%   -0.12%     
==========================================
  Files           8        8              
  Lines         419      426       +7     
==========================================
+ Hits          388      394       +6     
- Misses         31       32       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hillalex hillalex changed the title Suppot input data on log scale Support input data on log scale Oct 17, 2024
@hillalex hillalex merged commit 8155ae7 into main Oct 17, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant