Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some tidying up #24

Merged
merged 5 commits into from
Oct 23, 2024
Merged

Some tidying up #24

merged 5 commits into from
Oct 23, 2024

Conversation

hillalex
Copy link
Member

@hillalex hillalex commented Oct 23, 2024

  • use testthat edition 3 everywhere
  • use time_since_last_exp everywhere (instead of t_since_last_exp in places)
  • make tests that run the model a bit faster by using fewer iterations
  • replace RDS files of stan draws for tests with objects created using fit$save_object() rather than just saveRDS(fit) - the latter keeps references to temporary files that then get cleaned up and break the tests
  • fix code in manual test files

@hillalex hillalex marked this pull request as ready for review October 23, 2024 12:15
Copy link

codecov bot commented Oct 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.48%. Comparing base (8155ae7) to head (09b42bb).
Report is 6 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #24   +/-   ##
=======================================
  Coverage   92.48%   92.48%           
=======================================
  Files           8        8           
  Lines         426      426           
=======================================
  Hits          394      394           
  Misses         32       32           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hillalex hillalex merged commit 311babd into main Oct 23, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant