Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove trailing slash from api proxy route #21

Merged
merged 4 commits into from
Sep 25, 2024
Merged

remove trailing slash from api proxy route #21

merged 4 commits into from
Sep 25, 2024

Conversation

hillalex
Copy link
Member

@hillalex hillalex commented Sep 25, 2024

Fixes #20 by removing the trailing slash from the nginx proxy_pass config. The easiest way to avoid uris being decoded as they are passed to the proxied service is by removing the trailing slash, which means uris will be passed along exactly as they are to the API. This does mean that the API itself needs to serve routes that look like /api/whatever . PR
for this change in the API: seroanalytics/serovizr#14. This seemed like a safer fix than trying to write a custom rewrite directive. See this SO answer for details.

Copy link

codecov bot commented Sep 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.83%. Comparing base (f891080) to head (31ee7dd).
Report is 5 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #21   +/-   ##
=======================================
  Coverage   98.83%   98.83%           
=======================================
  Files          30       30           
  Lines         688      688           
  Branches      131      131           
=======================================
  Hits          680      680           
  Misses          8        8           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hillalex hillalex marked this pull request as ready for review September 25, 2024 10:34
@hillalex hillalex merged commit d71303d into main Sep 25, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] Can't get trace for biomarkers with slashes in them
1 participant