remove trailing slash from api proxy route #21
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #20 by removing the trailing slash from the
nginx
proxy_pass
config. The easiest way to avoid uris being decoded as they are passed to the proxied service is by removing the trailing slash, which means uris will be passed along exactly as they are to the API. This does mean that the API itself needs to serve routes that look like/api/whatever
. PRfor this change in the API: seroanalytics/serovizr#14. This seemed like a safer fix than trying to write a custom
rewrite
directive. See this SO answer for details.