Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor reducer #6

Merged
merged 1 commit into from
Sep 5, 2024
Merged

refactor reducer #6

merged 1 commit into from
Sep 5, 2024

Conversation

hillalex
Copy link
Member

@hillalex hillalex commented Sep 5, 2024

  • Ahead of adding configurable data scale, refactors root state to include a dictionary of dataset settings
  • Pulls out reducers into their own files
  • Also factors out ChooseDataset as a common component, to be used in the sidebar as well as the index page.

Copy link

codecov bot commented Sep 5, 2024

Codecov Report

Attention: Patch coverage is 95.04132% with 6 lines in your changes missing coverage. Please review.

Project coverage is 86.93%. Comparing base (20f23e8) to head (813a34d).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
src/components/App.tsx 0.00% 3 Missing ⚠️
src/reducers/datasetReducer.ts 93.54% 2 Missing ⚠️
src/hooks/usePersistedState.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main       #6      +/-   ##
==========================================
+ Coverage   86.74%   86.93%   +0.19%     
==========================================
  Files          15       18       +3     
  Lines         362      398      +36     
  Branches       73       74       +1     
==========================================
+ Hits          314      346      +32     
- Misses         48       52       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hillalex hillalex merged commit b7b44d5 into main Sep 5, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant