[#25] Handle 304 redirect #264
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Martoon-00
reviewed
Jan 12, 2023
aeqz
force-pushed
the
aeqz/#25-304-redirect
branch
from
49ec69a to
d7a7d90
Compare
Problem: After recent work on Xrefcheck redirect behavior, it remained to discuss how to handle 304 redirects. Solution: With the current default configuration, 304 redirects are considered as valid, which seems appropriate taking into account that 304 responses usually mean that you previously received a successful response for that same request and there is no need to retransmit the resource again. We add a test case for this default config and update the FAQ section.
aeqz
force-pushed
the
aeqz/#25-304-redirect
branch
from
d7a7d90 to
eccb6d0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Problem: after recent work on Xrefcheck redirect behavior, it remained to discuss how to handle 304 redirects.
Solution: with the current default configuration, 304 redirects are considered as valid, which seems appropriate taking into account that 304 responses usually mean that you previously received a successful response for that same request and there is no need to retransmit the resource again. We add a test case for this default config and update the FAQ section.
It is also related to conditional (e.g.
If-None-MatchandIf-Modified-Since) and cache request headers. As Xrefcheck does not send them when performing HTTP requests, usually it should not receive 304 redirects.Related issue(s)
Fixes #25
Related changes
Tests
silently reappearing again.
Documentation
Public contracts
of Public Contracts policy.
and
Stylistic guide