Skip to content

Commit

Permalink
derive: syn 2
Browse files Browse the repository at this point in the history
  • Loading branch information
serprex committed Nov 6, 2023
1 parent 4cdaa40 commit 1ddbc6c
Show file tree
Hide file tree
Showing 2 changed files with 20 additions and 20 deletions.
2 changes: 1 addition & 1 deletion derive/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,6 @@ edition = "2021"
proc-macro = true

[dependencies]
syn = "1.0"
syn = "2.0"
proc-macro2 = "1.0"
quote = "1.0"
38 changes: 19 additions & 19 deletions derive/src/lib.rs
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,8 @@ use proc_macro2::TokenStream;
use quote::{format_ident, quote, quote_spanned, ToTokens};
use syn::spanned::Spanned;
use syn::{
parse_macro_input, parse_quote, Attribute, Data, DeriveInput, Fields, GenericParam, Generics,
Ident, Index, Lit, Meta, MetaNameValue, NestedMeta,
parse_macro_input, parse_quote, Attribute, Data, DeriveInput, Expr, ExprAssign, ExprLit, ExprPath,
Fields, GenericParam, Generics, Ident, Index, Lit, Meta, MetaNameValue,
};


Expand Down Expand Up @@ -81,33 +81,33 @@ struct Attributes {
impl Attributes {
fn parse(attrs: &[Attribute]) -> Self {
let mut out = Self::default();
for attr in attrs.iter().filter(|a| a.path.is_ident("visit")) {
let meta = attr.parse_meta().expect("visit attribute");
match meta {
Meta::List(l) => {
for nested in &l.nested {
match nested {
NestedMeta::Meta(Meta::NameValue(v)) => out.parse_name_value(v),
_ => panic!("Expected #[visit(key = \"value\")]"),
}
}
for attr in attrs {
if let Meta::NameValue(ref namevalue) = attr.meta {
if namevalue.path.is_ident("visit") {
out.parse_name_value(namevalue);
}
_ => panic!("Expected #[visit(...)]"),
}
}
if out.with.is_none() {
panic!("Expected #[visit(...)]");
}
out
}

/// Updates self with a name value attribute
fn parse_name_value(&mut self, v: &MetaNameValue) {
if v.path.is_ident("with") {
match &v.lit {
Lit::Str(s) => self.with = Some(format_ident!("{}", s.value(), span = s.span())),
_ => panic!("Expected a string value, got {}", v.lit.to_token_stream()),
if let Expr::Assign(ExprAssign { ref left, ref right , ..}) = v.value {

Check failure on line 99 in derive/src/lib.rs

View workflow job for this annotation

GitHub Actions / docs

struct `ExprAssign` does not have fields named `left`, `right`

Check failure on line 99 in derive/src/lib.rs

View workflow job for this annotation

GitHub Actions / compile

struct `ExprAssign` does not have fields named `left`, `right`

Check failure on line 99 in derive/src/lib.rs

View workflow job for this annotation

GitHub Actions / lint

struct `ExprAssign` does not have fields named `left`, `right`

Check failure on line 99 in derive/src/lib.rs

View workflow job for this annotation

GitHub Actions / test (stable)

struct `ExprAssign` does not have fields named `left`, `right`

Check failure on line 99 in derive/src/lib.rs

View workflow job for this annotation

GitHub Actions / test (beta)

struct `ExprAssign` does not have fields named `left`, `right`

Check failure on line 99 in derive/src/lib.rs

View workflow job for this annotation

GitHub Actions / test (nightly)

struct `ExprAssign` does not have fields named `left`, `right`
if let Expr::Path(ExprPath { ref path, .. }) = **left {
if path.is_ident("with") {
match **right {
Expr::Lit(ExprLit { lit: Lit::Str(ref s), .. }) => self.with = Some(format_ident!("{}", s.value(), span = s.span())),
_ => panic!("Expected a string value, got {}", v.value.to_token_stream()),
}
return;
}
}
return;
}
panic!("Unrecognised kv attribute {}", v.path.to_token_stream())
panic!("Unrecognised kv attribute {}", v.to_token_stream())
}

/// Returns the pre and post visit token streams
Expand Down

0 comments on commit 1ddbc6c

Please sign in to comment.