Update windows-rs to 0.58 #346
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: sagudev <[email protected]>
mrobinson
approved these changes
Jul 29, 2024
|
Servo now has windows 0.58 in its dependencies. Does this still need to remain a draft? |
5 tasks
Not really, I just forgot. |
mrobinson
approved these changes
Aug 18, 2024
The problem is that even that if it does not works the bugs are subtile (most changes are in error handling which happens rarely, and we only run smoketest for win, we need windows-wpt). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #345.
My first time working with windows-rs, so review carefully. I tried to stick to the current code schematic, but the whole codebase would need a cleanup (a lot of clippy warnings).
Draft because I want a companion PR in servo.