Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accept EINVAL errors in make_socket_lingering #370

Merged
merged 1 commit into from
Oct 18, 2024
Merged

Conversation

sunshowers
Copy link
Contributor

See included comment for why this is necessary. This is required to make the server_connect_first test pass on illumos.

See included comment for why this is necessary. This is required to make the
`server_connect_first` test pass on illumos.
Copy link
Member

@jdm jdm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems reasonable! Thanks for the comment explaining it.

@jdm jdm enabled auto-merge October 18, 2024 22:01
@jdm jdm added this pull request to the merge queue Oct 18, 2024
Merged via the queue into servo:main with commit 7d5900d Oct 18, 2024
17 checks passed
@sunshowers sunshowers deleted the einval branch October 18, 2024 22:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants