Prepare url crate for publication with idna 1.0.3 #987
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## idna-v1x #987 +/- ##
============================================
- Coverage 80.50% 80.41% -0.10%
============================================
Files 24 24
Lines 4253 4253
============================================
- Hits 3424 3420 -4
- Misses 829 833 +4 ☔ View full report in Codecov by Sentry. |
valenting
approved these changes
Nov 4, 2024
github-merge-queue bot
pushed a commit
that referenced
this pull request
Nov 4, 2024
* Adjust Punycode overflow checks * The change made in 1.0.0 incorrectly assumed that the input length limit removed the need to do overflow check when decoding. Now the internal-caller length limit is taken as a permission to skip overflow checks only when encoding. * The RFC gives overflow checking pre-flight math for languages like that don't have checked math. Since Rust does, the code now uses checked_add and checked_mul instead of pre-flight when overflow checks are performed. * Remove no_std category (crates.io doesn't support it, and it is now rejected), use keywords instead * Add benches that use the main idna 1.0 entry point in idna and url * Put the Unicode back end behind an adapter crate * Split fastest ASCII fast path from the rest * Bench hyphen in a domain that is otherwise lower-case ASCII * Adjust MSRV * Add README remarks about alternative Unicode back ends * Change the idna_adapter dependency to crates.io * Address clippy lints * Increment version number of idna to 1.0.3 * Test MSRV with idna unicode-rs back end and test ICU4X back end with 1.67 * Prepare url crate for publication with idna 1.0.3 (#987) --------- Co-authored-by: Manish Goregaokar <[email protected]> Co-authored-by: Valentin Gosu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prepare the idna-v1x branch so that
url2.5.3 depending onidna1.0.3 could be published from it.However, instead of actually publishing
url2.5.3 andidna1.0.3 from the idna-v1x branch, my expectation is that after this PR has landed, we'd merge idna-v1x into main, at which pointurl2.5.3 andidna1.0.3 could be published from main and the idna-v1x branch would become obsolete.