Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix mutating path of URL without authority (idempotency, empty path segments) #996

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

theskim
Copy link
Contributor

@theskim theskim commented Nov 8, 2024

From Issue #984

Copy link

codecov bot commented Nov 8, 2024

Codecov Report

Attention: Patch coverage is 93.18182% with 3 lines in your changes missing coverage. Please review.

Please upload report for BASE (main@7492360). Learn more about missing BASE report.

Files with missing lines Patch % Lines
url/src/path_segments.rs 88.88% 2 Missing ⚠️
url/src/lib.rs 96.15% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #996   +/-   ##
=======================================
  Coverage        ?   80.50%           
=======================================
  Files           ?       24           
  Lines           ?     4272           
  Branches        ?        0           
=======================================
  Hits            ?     3439           
  Misses          ?      833           
  Partials        ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@valenting valenting left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If I'm not mistaken, these failing tests should also be made to pass as part of this test

<non-spec:/.//p> set hostname to <h>
<non-spec:/.//p> set hostname to <>

That's about mutating the host, not the path, but I think the behaviour is closely related to this one.

url/tests/unit.rs Show resolved Hide resolved
Copy link
Collaborator

@valenting valenting left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the delayed review. See inline:

url/tests/unit.rs Outdated Show resolved Hide resolved
url/src/lib.rs Outdated Show resolved Hide resolved
url/src/lib.rs Show resolved Hide resolved
@theskim
Copy link
Contributor Author

theskim commented Nov 20, 2024

@valenting, should I be worried about this failure?

@valenting
Copy link
Collaborator

It seems the MSRV for libc changed
rust-lang/libc@77b3ea4#diff-06572a96a58dc510037d5efa622f9bec8519bc1beab13c9f251e97e657a9d4edR9

Feel free to also increase ours to 1.63

@valenting
Copy link
Collaborator

Note: I think we need to add #943 to this PR considering we backed it out in #999

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants