-
Notifications
You must be signed in to change notification settings - Fork 331
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix mutating path of URL without authority (idempotency, empty path segments) #996
base: main
Are you sure you want to change the base?
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #996 +/- ##
=======================================
Coverage ? 80.50%
=======================================
Files ? 24
Lines ? 4272
Branches ? 0
=======================================
Hits ? 3439
Misses ? 833
Partials ? 0 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If I'm not mistaken, these failing tests should also be made to pass as part of this test
rust-url/url/tests/expected_failures.txt
Lines 39 to 40 in da64903
<non-spec:/.//p> set hostname to <h> | |
<non-spec:/.//p> set hostname to <> |
That's about mutating the host, not the path, but I think the behaviour is closely related to this one.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for the delayed review. See inline:
@valenting, should I be worried about this failure? |
It seems the MSRV for libc changed Feel free to also increase ours to 1.63 |
From Issue #984