Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump version to 0.9.4 #295

Merged
merged 1 commit into from
Jun 11, 2024
Merged

Bump version to 0.9.4 #295

merged 1 commit into from
Jun 11, 2024

Conversation

jschwe
Copy link
Member

@jschwe jschwe commented Jun 10, 2024

No description provided.

@jschwe
Copy link
Member Author

jschwe commented Jun 10, 2024

@mrobinson Could you perhaps create a new crates.io release? This is basically the last dependency bump blocking me

@mrobinson
Copy link
Member

This look great! Sorry for not releasing earlier. To land we'll just need to fix the Windows CI like we recently did for Servo (essentially just upgrading LLVM with choco). I can do that and also land this change tomorrow.

@jschwe jschwe force-pushed the patch-1 branch 2 times, most recently from 269a6f9 to daf655d Compare June 10, 2024 17:22
@jschwe
Copy link
Member Author

jschwe commented Jun 10, 2024

Hmm, I added your fix from the main servo repo here, but it seems that the build is stuck on windows. Maybe we can retry tomorrow and see if it gets stuck consistently.

Edit: Still gets stuck on the build-script-build of mozangle

@mrobinson
Copy link
Member

I've gotten a slightly different version of the workaround functioning here: #296

@jschwe
Copy link
Member Author

jschwe commented Jun 11, 2024

Great! How about you also bump the version on your PR, and I'll just close mine?

@mrobinson
Copy link
Member

Great! How about you also bump the version on your PR, and I'll just close mine?

I'm happy to keep them as two separate PRs since they do different things. Then if we ever need to revert one, we can keep the other.

@jschwe
Copy link
Member Author

jschwe commented Jun 11, 2024

Okay, dropped the workaround commit on my end

@mrobinson mrobinson added this pull request to the merge queue Jun 11, 2024
Merged via the queue into servo:main with commit a127db7 Jun 11, 2024
17 checks passed
@mrobinson
Copy link
Member

I've published the release: https://crates.io/crates/surfman/0.9.4

@jschwe jschwe deleted the patch-1 branch June 11, 2024 11:14
@jschwe
Copy link
Member Author

jschwe commented Jun 11, 2024

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants