[SES-3593] - Disable KDF for sqlcipher #1081
Open
+1,005
−512
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR effectively disables the kdf in sqlcipher. The reason we want to do this:
For reference document on kdf, see https://www.zetetic.net/sqlcipher/sqlcipher-api/#kdf_iter
This PR also moves the initilisation of
SQLCipherOpenHelper
to a lazy loading fashion so that the expensive migration will only happen when database access is required. This means all the database classes shouldn't access to the helper directly, they should all use thegetReadableDatabase/getWritableDatabase
from the base class.