Skip to content

Removing control message checks from utility functions #37

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Removing control message checks from utility functions #37

wants to merge 2 commits into from

Conversation

burtonemily
Copy link
Collaborator

No description provided.

Bilb
Bilb requested changes Apr 17, 2025
View reviewed changes
run/test/specs/group_tests_create_group.spec.ts Outdated
await createGroup(platform, device1, userA, device2, userB, device3, userC, testGroupName);
// Close server and devices

const userAMessage = `${userOne.userName} to ${testGroupName}`;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this on purpose that you pasted the whole createGroup function here?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah, essentially I want to test the functionality of creating a group but with the control message checks and leave the createGroup function clear (so its just a utility function).

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe that should be a boolean argument in the createGroup function instead, where we skip, or not skip some stuffs?
duplicating code is bad

run/test/specs/user_actions_create_contact.spec.ts

await newContact(platform, device1, userA, device2, userB);
// await newContact(platform, device1, userA, device2, Bob);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same comment

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as above, still want to do the action of creating a contact but with the control message checks and remove the checks from the function

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Bilb Bilb Bilb requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@burtonemily @Bilb