fix: handle cases where compressed representation is larger than input array #21
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The fpzip algorithm can sometimes require a larger buffer than the input array size (pigeonhole principle). The extra 4 bytes in
header_bytes
was enough to mostly hide this issue, but we ran into a buffer overflow exception in production. Instead of always using the input array size + header size as the compression buffer size, try with this size and incrementally expand the buffer if it's not enough.In the overwhelmingly common case (compressed size < input size), no extra work is done, only if the buffer is too small do we do any extra work. The values for
MAX_ATTEMPTS
andBUFFER_GROWTH_FACTOR
are somewhat arbitrary, but 5 and 1.5 seem good enough. It would only be truly pathological inputs that would require more than this.