Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft: feat: add @ima/testing-library #576

Merged
merged 17 commits into from
Sep 17, 2024
Merged

Draft: feat: add @ima/testing-library #576

merged 17 commits into from
Sep 17, 2024

Conversation

Filipoliko
Copy link
Contributor

No description provided.

Copy link

changeset-bot bot commented Aug 15, 2024

🦋 Changeset detected

Latest commit: a17b9be

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 5 packages
Name Type
create-ima-app Minor
@ima/storybook-integration Patch
@ima/server Patch
@ima/core Patch
@ima/testing-library Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@Filipoliko Filipoliko changed the title feat: add @ima/testing-library Draft: feat: add @ima/testing-library Aug 15, 2024
…lt server config; rewrite enzyme tests to itl
@Filipoliko
Copy link
Contributor Author

Filipoliko commented Aug 19, 2024

@mjancarik Is @ima/devtools still being used? There are some enzyme tests, which need to be rewritten to RTL, but there is no IMA specific logic, so there is no need for @ima/testing-library.

Edit: @ima/devtools is sort of dead, but it would be nice to revive it at some point. If we get there, we will rewrite the tests at that point of time.

@Filipoliko
Copy link
Contributor Author

Current solution is not trying to cleanup any hanging IMA applications. It creates a new IMA app with each initImaApp (or renderWithContext) call. Then we loose a reference to the ima app variable so maybe the cleanup is done sort of automatically.

Or do we need to do some cleanup of hanging apps maybe before initImaApp (or by setting some default afterEach cleanup script)?

@Filipoliko Filipoliko merged commit 706c736 into master Sep 17, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants