Separate benchmark assignment modal from trpc #489
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We refactored BenchmarkAssignmentModal to separate out the para selection step. This will allow for more modular frontend unit testing.
canjalal
reviewed
Feb 4, 2025
| @@ -12,6 +12,7 @@ | |||
| "type-css:check": "npx tcm src --listDifferent", | |||
| "test": "next build --no-lint && ava", | |||
| "test-storybook": "test-storybook --maxWorkers=2", | |||
| "docker-reup": "docker compose -f supporting_services/docker-compose.yml up -d", | |||
| @@ -94,7 +94,7 @@ test("basic flow - add/get goals, benchmarks, tasks", async (t) => { | |||
| const gotBenchmark = await trpc.iep.getBenchmark.query({ | |||
| benchmark_id: benchmark2Id, | |||
| }); | |||
| t.is(gotBenchmark[0].description, "benchmark 2"); | |||
| t.is(gotBenchmark.description, "benchmark 2"); | |||
| @@ -133,55 +69,26 @@ export const BenchmarkAssignmentModal = ( | |||
| <DialogContent> | |||
| <Box className={$benchmark.benchmarkDescriptionBox}> | |||
| <p className={$benchmark.benchmarkTitle}>Benchmark</p> | |||
| {benchmark?.map((thisBenchmark) => ( | |||
There was a problem hiding this comment.
Thank you for separating this out!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tease apart assignment modal UI from trpc request