Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add react-query package #36

Merged
merged 7 commits into from
Mar 7, 2024
Merged

Add react-query package #36

merged 7 commits into from
Mar 7, 2024

Conversation

ddrosario
Copy link
Contributor

No description provided.

@ddrosario
Copy link
Contributor Author

I added React-query as a dependency but should I include something else like an example request?

@francisli
Copy link
Contributor

@ddrosario maybe hit one of the sample endpoints in our fastify server?

@ddrosario ddrosario force-pushed the feature-4-react-query branch from 1a49b9b to 71aad06 Compare February 22, 2024 02:43
@ddrosario
Copy link
Contributor Author

I'm not sure if others are having similar issues with running the project. I was having issues with Vite and I had to install the following 3 packages in order to get the project to run. I also had to move the BrowserRouter up a level to main.jsx.

  • @rollup/rollup-linux-x64-gnu
  • @swc/cli
  • @swc/core

I can move these changes to another PR if needed.

@francisli
Copy link
Contributor

I'm not sure if others are having similar issues with running the project. I was having issues with Vite and I had to install the following 3 packages in order to get the project to run. I also had to move the BrowserRouter up a level to main.jsx.

* `@rollup/rollup-linux-x64-gnu`

* `@swc/cli`

* `@swc/core`

I can move these changes to another PR if needed.

Hmm, what's your development setup? Are you using Docker, or running locally on your OS? What OS are you using?

@ddrosario
Copy link
Contributor Author

Hmm, what's your development setup? Are you using Docker, or running locally on your OS? What OS are you using?


I am running Mac OS, but I'm just running the project via docker container `docker compose up`. I found out about these dependencies by connecting into the docker container and trying to install/run from there.

@ddrosario
Copy link
Contributor Author

I did a fresh install and it's building now. 🤷 I removed those peer dependencies

@ddrosario ddrosario force-pushed the feature-4-react-query branch from 9eedaa2 to 392b29d Compare February 29, 2024 03:24
Copy link
Contributor

@francisli francisli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, works for me in testing...!

@francisli francisli linked an issue Mar 7, 2024 that may be closed by this pull request
@francisli francisli merged commit 9faaa83 into dev Mar 7, 2024
1 check passed
@francisli francisli deleted the feature-4-react-query branch March 7, 2024 23:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Integrate TanStack React Query into client
2 participants