Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ballle98/AqualinkD#8: replace busy polling with pthread_cond_wait #100

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

ballle98/AqualinkD#8: replace busy polling with pthread_cond_wait #100

wants to merge 1 commit into from

Conversation

ballle98
Copy link
Contributor

@ballle98 ballle98 commented Dec 9, 2019

fix #99

@ballle98
Copy link
Contributor Author

@sfeakes updated branch to 2.2.2a++ using condition timed wait and signals is far more efficient and reliable than polling.

@sfeakes
Copy link
Owner

sfeakes commented Sep 14, 2020 •
edited
Loading

I really like what you have done here, but I think it'll break the other protocols. (wait after send for command to clear). I'll pull it later in the week and check it, as it'll take a lot to test all the things that can break with the timings.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

replace busy polling with pthread_cond_wait
2 participants
@ballle98 @sfeakes