Move check for UID 0 (i.e. root) to after the options parsing. #101
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Additionally, refactor the options parsing to use getopt() so that it can handle unknown options, missing parameters, and "long" options (i.e. --help vs. -h).
ballle98
reviewed
Dec 19, 2019
- Should count "-v" parameters for verbosity - Extra short options incorrect added for long options Additionally, added constants for the short options to reduce likelihood of flag typos.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Under certain circumstances, options are evaluated after a UID == 0 (i.e. is root) check. That means that invalid options such as -c without a parameter would not be detected and the help screen displayed unless the user is root. Additionally long form options (e.g. --help vs. -h) are not supported nor are validation checks for parameters.
This pull request refactors the options parsing to use getopt_long() so that unknown options, missing parameters, and "long" options are all handled. Additionally, it moves the root check to after option parsing to that users don't have to be root to view the help screen.