Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix / Subaccount topup and account summary query #371

Conversation

scorpioborn
Copy link
Contributor

Description


Type of change

Please check the options that are relevant. This PR introduces

  • Patch: Bug fix (non-breaking change which fixes an existing issue)
  • Minor: New feature (non-breaking change which adds new functionality)
  • Major: Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Features Description

  • NA

Test Cases

  • NA

Documentation


Checklist:

  • I have added change type (major|minor|patch) in the PR
  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@codecov-commenter
Copy link

codecov-commenter commented Mar 16, 2024

Codecov Report

Attention: Patch coverage is 32.12435% with 131 lines in your changes are missing coverage. Please review.

Project coverage is 11.60%. Comparing base (8fbca35) to head (fedbc9a).

Files Patch % Lines
x/subaccount/types/query.pb.go 0.00% 71 Missing ⚠️
x/orderbook/types/query.pb.gw.go 0.00% 10 Missing ⚠️
x/subaccount/keeper/balance.go 81.08% 4 Missing and 3 partials ⚠️
x/orderbook/types/query.pb.go 0.00% 5 Missing ⚠️
x/reward/types/reward.go 0.00% 5 Missing ⚠️
x/subaccount/keeper/subaccount.go 66.66% 4 Missing ⚠️
x/reward/types/reward_signup.go 0.00% 3 Missing ⚠️
x/reward/types/reward_signup_affiliatee.go 0.00% 3 Missing ⚠️
x/reward/types/reward_signup_affiliator.go 0.00% 3 Missing ⚠️
x/reward/types/reward_signup_referee.go 0.00% 3 Missing ⚠️
... and 9 more

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@                       Coverage Diff                       @@
##           fix/missing-locked-balances     #371      +/-   ##
===============================================================
- Coverage                        11.63%   11.60%   -0.03%     
===============================================================
  Files                              351      351              
  Lines                            45621    45689      +68     
===============================================================
- Hits                              5307     5304       -3     
- Misses                           39834    39905      +71     
  Partials                           480      480              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@scorpioborn scorpioborn marked this pull request as ready for review March 18, 2024 15:49
@scorpioborn scorpioborn requested review from 3eyedraga and a team as code owners March 18, 2024 15:49
@scorpioborn scorpioborn changed the base branch from master to fix/missing-locked-balances March 19, 2024 09:30
@scorpioborn scorpioborn merged commit f0e2db9 into sge-network:fix/missing-locked-balances Mar 19, 2024
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants