Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature / Campaign custom withdraw amount #378

Conversation

scorpioborn
Copy link
Contributor

@scorpioborn scorpioborn commented Mar 28, 2024

Description

Add authorization withdrawal limit to the campaign withdrawal transaction.


Type of change

Please check the options that are relevant. This PR introduces

  • Patch: Bug fix (non-breaking change which fixes an existing issue)
  • Minor: New feature (non-breaking change which adds new functionality)
  • Major: Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Features Description

  • Added amount to withdrawal
  • Implement Authorization with withdrawal limit
  • Track the withdrawn amount instead of making the total amount zero
  • Multiple withdrawal is possible

Test Cases

  • NA

Documentation


Checklist:

  • I have added change type (major|minor|patch) in the PR
  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@github-actions github-actions bot added the C:CLI label Mar 28, 2024
@codecov-commenter
Copy link

codecov-commenter commented Mar 28, 2024

Codecov Report

Attention: Patch coverage is 5.03597% with 132 lines in your changes are missing coverage. Please review.

Project coverage is 11.58%. Comparing base (977c6da) to head (6be1551).

Files Patch % Lines
x/reward/types/authz.pb.go 0.00% 33 Missing ⚠️
x/reward/types/campaign.pb.go 0.00% 33 Missing ⚠️
x/reward/types/tx.pb.go 0.00% 33 Missing ⚠️
x/reward/types/campaign_authorizaton.go 0.00% 23 Missing ⚠️
x/reward/keeper/msg_server_campaign.go 14.28% 6 Missing ⚠️
x/reward/types/pool.go 62.50% 3 Missing ⚠️
x/reward/types/messages_campaign.go 0.00% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #378      +/-   ##
==========================================
- Coverage   11.60%   11.58%   -0.03%     
==========================================
  Files         351      351              
  Lines       45689    45815     +126     
==========================================
+ Hits         5304     5306       +2     
- Misses      39905    40029     +124     
  Partials      480      480              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@scorpioborn scorpioborn marked this pull request as ready for review March 28, 2024 08:19
@scorpioborn scorpioborn requested review from 3eyedraga and a team as code owners March 28, 2024 08:19
@scorpioborn scorpioborn changed the base branch from master to release/v1.6.x April 2, 2024 08:54
@3eyedraga 3eyedraga merged commit b7d106e into sge-network:release/v1.6.x Apr 2, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants