Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor / Disable all modules deprecated txs #441

Merged
merged 7 commits into from
Nov 4, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/codeql.yml
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ on:
schedule:
- cron: '26 6 * * 2'
env:
GO_VERSION: 1.22
GO_VERSION: 1.23

jobs:
analyze:
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/lint.yml
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ on:
- master

env:
GO_VERSION: '1.22'
GO_VERSION: '1.23'

jobs:
golangci:
Expand Down
10 changes: 5 additions & 5 deletions .github/workflows/test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ jobs:
steps:
- uses: actions/setup-go@v5
with:
go-version: 1.22
go-version: 1.23
- name: Display go version
run: go version
- name: install tparse
Expand All @@ -42,7 +42,7 @@ jobs:
- uses: actions/checkout@v4
- uses: actions/setup-go@v5
with:
go-version: 1.22
go-version: 1.23
- uses: technote-space/get-diff-action@v4
id: git_diff
with:
Expand Down Expand Up @@ -81,7 +81,7 @@ jobs:
steps:
- uses: actions/setup-go@v5
with:
go-version: 1.22
go-version: 1.23
- uses: actions/checkout@v4
- name: Create a file with all the pkgs
run: go list ./... | grep -E -v 'tests/e2e' > pkgs.txt
Expand Down Expand Up @@ -116,7 +116,7 @@ jobs:
- uses: actions/checkout@v4
- uses: actions/setup-go@v5
with:
go-version: 1.22
go-version: 1.23
- uses: technote-space/get-diff-action@v4
with:
PATTERNS: |
Expand Down Expand Up @@ -194,7 +194,7 @@ jobs:
- uses: actions/checkout@v4
- uses: actions/setup-go@v5
with:
go-version: 1.22
go-version: 1.23
- uses: technote-space/get-diff-action@v4
with:
PATTERNS: |
Expand Down
14 changes: 11 additions & 3 deletions .golangci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@ run:
timeout: 15m
sort-results: true
allow-parallel-runners: true
exclude-dir: testutil/testdata_pulsar
concurrency: 4

linters:
Expand All @@ -16,7 +15,7 @@ linters:
- durationcheck
- errcheck
- errname
- exportloopref
- copyloopvar
- forcetypeassert
- goconst
- gofmt
Expand Down Expand Up @@ -48,7 +47,16 @@ linters:
- revive

issues:
exclude-rules: []
exclude-rules:
- path: (.+)_test.go
linters:
- gosec
- path: suite.go
linters:
- gosec
- path: testutil
linters:
- gosec
max-issues-per-linter: 10000
max-same-issues: 10000

Expand Down
2 changes: 1 addition & 1 deletion Dockerfile
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
# syntax=docker/dockerfile:1

ARG GO_VERSION="1.22"
ARG GO_VERSION="1.23"
ARG RUNNER_IMAGE="gcr.io/distroless/static-debian11"
ARG BUILD_TAGS="netgo,ledger,muslc"

Expand Down
4 changes: 2 additions & 2 deletions Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -115,8 +115,8 @@ endif
###############################################################################

check_version:
ifneq ($(GO_MINOR_VERSION),22)
@echo "ERROR: Go version 1.22 is required for this version of SGE."
ifneq ($(GO_MINOR_VERSION),23)
@echo "ERROR: Go version 1.23 is required for this version of SGE."
exit 1
endif

Expand Down
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ At launch, the SGE Network will be optimized to deploy an inaugural application:

## Installation Steps
>
>Prerequisite: go1.22+ required. [ref](https://golang.org/doc/install)
>Prerequisite: go1.23+ required. [ref](https://golang.org/doc/install)

Sge could be installed by two ways - downloading binary from releases page or build from source.

Expand Down
4 changes: 2 additions & 2 deletions app/upgrades/v10/consts.go
Original file line number Diff line number Diff line change
Expand Up @@ -6,8 +6,8 @@ import (
"github.com/sge-network/sge/app/upgrades"
)

// UpgradeName defines the on-chain upgrade name for the v1.7.4 upgrade.
const UpgradeName = "v1.7.4"
// UpgradeName defines the on-chain upgrade name for the v1.7.5 upgrade.
const UpgradeName = "v1.7.5"

var Upgrade = upgrades.Upgrade{
UpgradeName: UpgradeName,
Expand Down
2 changes: 1 addition & 1 deletion app/upgrades/v10/upgrades.go
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ func CreateUpgradeHandler(
configurator module.Configurator,
_ *keepers.AppKeepers,
) upgradetypes.UpgradeHandler {
return func(ctx sdk.Context, plan upgradetypes.Plan, fromVM module.VersionMap) (module.VersionMap, error) {
return func(ctx sdk.Context, _ upgradetypes.Plan, fromVM module.VersionMap) (module.VersionMap, error) {
return mm.RunMigrations(ctx, configurator, fromVM)
}
}
4 changes: 1 addition & 3 deletions app/upgrades/v9/upgrades.go
Original file line number Diff line number Diff line change
Expand Up @@ -43,12 +43,10 @@ func CreateUpgradeHandler(
configurator module.Configurator,
k *keepers.AppKeepers,
) upgradetypes.UpgradeHandler {
return func(ctx sdk.Context, plan upgradetypes.Plan, fromVM module.VersionMap) (module.VersionMap, error) {
return func(ctx sdk.Context, _ upgradetypes.Plan, fromVM module.VersionMap) (module.VersionMap, error) {
// https://github.com/cosmos/cosmos-sdk/pull/12363/files
// Set param key table for params module migration
for _, subspace := range k.ParamsKeeper.GetSubspaces() {
subspace := subspace

var keyTable paramstypes.KeyTable
switch subspace.Name() {
case authtypes.ModuleName:
Expand Down
1 change: 0 additions & 1 deletion cmd/sged/cmd/genaccounts_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,6 @@ func TestSampleCMD(t *testing.T) {
args: []string{},
},
} {
tc := tc
t.Run(tc.desc, func(t *testing.T) {
var args []string

Expand Down
Loading
Loading