Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dark mode support for visualizer canvas #184

Merged
merged 1 commit into from
Jan 31, 2025
Merged

Conversation

Jamesgt
Copy link

@Jamesgt Jamesgt commented Jan 27, 2025

My OS is set to use dark mode and Monaco editor has dark background, to see the logs the devtools is also in dark mode.
The only part not respecting the preferred setting is the threejs canvas.

@sgenoud
Copy link
Owner

sgenoud commented Jan 31, 2025

Thanks! I took the opportunity to improve the dark mode a bit in other places!

@sgenoud sgenoud merged commit 6c3684f into sgenoud:main Jan 31, 2025
@Jamesgt
Copy link
Author

Jamesgt commented Feb 3, 2025

I really appreciate!

But now the ErrorOverlay has light bg and lightgrey text, so that should be aligned also.
I don't see it set in the code, so maybe the styled-components lib is adding that default.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants