Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sgkit.genee improvements #1181

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

Conversation

jdstamp
Copy link
Collaborator

@jdstamp jdstamp commented Jan 27, 2024

  • Improves documentation of input and output for sgkit.genee
  • The Example for the sgkit.genee doc string is not a final version. It would need a better treatment of the LD matrix situation to be useful. The major point of this suggestion is to start a discussion about how to make the method more usable and also have an example that explains a user how to provide windows for regions of interest.
  • Changing the example code to have more contigs and overlapping windows in different contigs produces some edge cases that are not handled by the method.
  • How can the test_genee.py file be made active during unit tests? I was only able to run it specifically using pytest -v path/to/file. I added the path to the data default because I don't know how to properly configure that as part of the testing framework.
  • Accompanies genee review: sgkit implementation limitations #1180

@jdstamp jdstamp requested review from tomwhite and hammer January 27, 2024 22:36
Copy link
Collaborator

@tomwhite tomwhite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These look good to me. Thanks @jdstamp!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants