Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use sgkit.distarray for PCA #1274

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

tomwhite
Copy link
Collaborator

More progress on #908

This needs cubed-dev/cubed#598 which hasn't been merged yet

@tomwhite tomwhite marked this pull request as draft October 28, 2024 13:12
@tomwhite
Copy link
Collaborator Author

This is working, now that SVD for Cubed has been merged.

This change involves adding a copy of TruncatedSVD from Dask-ML, suitably modified to support the Array API, as well as Dask. Since this was the only code we use from Dask-ML it allows us to remove the Dask-ML dependency.

In the future we may be able to remove the copy of TruncatedSVD entirely, and use the original from scikit-learn - but only once it has been converted to be Array API compatible (note that regular PCA has already been converted).

@tomwhite tomwhite marked this pull request as ready for review November 18, 2024 11:43
Copy link
Collaborator

@jeromekelleher jeromekelleher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great - num_dependencies -= 1!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants