Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vcztools query: optimize query evaluation #84

Open
Will-Tyler opened this issue Sep 27, 2024 · 2 comments
Open

vcztools query: optimize query evaluation #84

Will-Tyler opened this issue Sep 27, 2024 · 2 comments

Comments

@Will-Tyler
Copy link
Contributor

Description

With the --include and --exclude flags introduced in #82, users can filter variant sites for inclusion in the output. The current implementation evaluates the query for all of the variant sites, even if many of the variant sites are not selected by the filters. If no variant sites in a chunk are selected by the filters, an optimization can be made by not reading the chunk and not evaluating the query for those variant sites.

References

@Will-Tyler
Copy link
Contributor Author

I think this task is much easier to implement with uniform chunk layouts (sgkit-dev/vcf-zarr-spec#22).

@jeromekelleher
Copy link
Contributor

I think we can assume uniform chunk layouts. The best thing to do would be to raise an error in the bit of the code that's doing the query optimisation if the arrays its dealing with don't all have the required chunk layout.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants