-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix maximum recursion depth triggered on exception exit #3519
base: main
Are you sure you want to change the base?
Conversation
Hey I don't think this fix the error: Your current patch only addresses scenarios where SIGKILL might not be effective by adding an additional SIGQUIT attempt. It does not prevent psutil from entering a deep recursion when invoked in a signal handler to inspect the current process’s children. To fully resolve the RecursionError it's better to refactor the signal-handling approach—avoiding complex psutil calls inside the signal handler—and/or update how you gather and kill child processes. |
Thanks, I will review it later and modify it. |
@kebe7jun Have you done it? |
I tried reproducing locally, but without success, can you provide some inspirations? |
@kebe7jun I will merge it thanks. |
@zhaochenyang20 hi, can this pr be merged? |
@kebe7jun If the CI goese well. I will merge it later... |
@zhaochenyang20 ci goes well. |
Fix #3518
Motivation
Modifications
Checklist