Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

xgrammar 0.1.13 #3593

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

Conversation

qeternity
Copy link
Contributor

Motivation

Xgrammar compiler now supports regex compilation directly and the latest contains fixes (e.g. lazy groups) which bring it closer to parity with Outlines.

Modifications

Upgrade deps and migrate to regex compiler.

Checklist

@zhyncs
Copy link
Member

zhyncs commented Feb 16, 2025

There are some issues with 0.1.13, please wait for @Ubospica to release a new version.

@zhyncs zhyncs marked this pull request as draft February 16, 2025 15:06
@qeternity
Copy link
Contributor Author

@zhyncs understood, thanks for the review and info.

I presume the issues you reference are build related? Installing from wheel passed our internal smoke tests fwiw.

@Ubospica
Copy link
Contributor

Ubospica commented Feb 17, 2025

@qeternity Yes the CI fails because xgrammar's new version contains a kernel not compatible with CUDA<12.4. It should work properly for CUDA>=12.4. We have fixed this issue (mlc-ai/xgrammar#206) and will release a new version later.

@qeternity
Copy link
Contributor Author

@Ubospica gotcha. We are running 12.4 so I guess that explains things :)

@zhyncs
Copy link
Member

zhyncs commented Feb 18, 2025

Ah Currently SGLang is using CUDA 12.1 for the CIs :)
ref https://github.com/sgl-project/sglang/blob/main/docs/developer/setup_github_runner.md#step-1-start-a-docker-container
Maybe we should upgrade CUDA 12.4 @merrymercy @Ying1123

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants