Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve LinearBase circular import #3833

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

zhengy001
Copy link
Contributor

@zhengy001 zhengy001 commented Feb 25, 2025

Motivation

Resolve the following import error by lazy import. Mainly from this PR: vllm-project/vllm@388ee3d

import sglang
import sglang.srt.models.phi3_small

ImportError: cannot import name 'LinearBase' from partially initialized module 'sglang.srt.layers.linear' (most likely due to a circular import)

Modifications

Checklist

@zhaochenyang20
Copy link
Collaborator

Thanks. This looks good to me. Could @FrankLeeeee Take a look?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants