Revert recent changes #3845
Open
Revert recent changes #3845
+6
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
merrymercy
reviewed
Feb 25, 2025
|
|
||
| ```bash | ||
| pip install --upgrade pip | ||
| pip install "sglang[all]>=0.4.3.post2" --find-links https://flashinfer.ai/whl/cu124/torch2.5/flashinfer-python | ||
| pip install uv | ||
| uv pip install sgl-kernel --force-reinstall --no-deps |
There was a problem hiding this comment.
Why do you need this additional command to install sgl kernel? Can you just remove it?
merrymercy
reviewed
Feb 25, 2025
| @@ -29,6 +32,7 @@ git clone -b v0.4.3.post2 https://github.com/sgl-project/sglang.git | |||
| cd sglang | |||
|
|
|||
| pip install --upgrade pip | |||
| pip install sgl-kernel --force-reinstall --no-deps | |||
There was a problem hiding this comment.
let me take a look later into this. i will try if it works without installing the kernel.
so far we always included that into the installment docs so i assumed it is needed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
See this issue
@zhaochenyang20