-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add CI tests for benchmarks. #2
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
shachlanAmazon
commented
Dec 5, 2023
- Allow benchmarks to run in a minimal fashion, that shouldn't take a long while.
- Add CI task for each language, so that benchmarks will run for it.
- Add relevant file extensions for changes that should trigger CI for each language.
Python - config rewrite command
Merging updates from redis-rs
Throw concrete error types from node client.
Fixing Python's INFO parser to support parsing Redis 7.2 INFO output
JS might perform a lot of tests when checking if an object is truthy.
This saves the cost of allocating a new error on every promise. Apparently this has a significant perf cost.
Fix node's performance degradation.
Removed the FFI client from the Python wrapper
update the doc comments to TSDoc
Updates from redis-rs
Fixed config rewrite tests
…ssmethod functions
…stems and Python versions.
Create bug-report.yml
…empl Create feature-request.yml
* Align indentation for java .yml files. All other .yml files use this indentation. * Run Java's CI only on branch pushes to main. We don't need to run CI on every push to every development branch.
These timeouts carry a significant performance penalty. Their benefit is more precise timeouts to the user, but we're willing to be off by a bit in order to improve perf.
This means that if you pass the `--stripInternal` flag to `tsc`, these functions won't be emitted in the typescript declaration files, and we won't expose the protobuf types. temp
Added redis installation guide to node README
* Remove csharp socket client. * C#: Use our client, not the redis-rs multiplexer. * Use generics in MessageContainer. This allows us to move some of the message logic to MessageContainer. * Fix benchmark program. * Message: Implement awaiter. `Message` now implements GetAwaiter, which allows the TPL to await on `Message`s, which is much more efficient, and removes the need for `ValueTask`s. As a part of the change, now `Message`s report to their `MessageContainer` when they complete an action, and can be made available again. Additionally, `Message`s now can return `null` regardless of their generic type - this is done in order to remove a warning, since the code can't ensure that the returned value isn't `null` without additional runtime checks, and `null` values are legal in our flows. * re-enable csharp github actions. * Fix compilation. * PR comments. * C#: Rename connection to client. --------- Co-authored-by: nihohit <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.