Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(example): Prevent hydration error in music example #1569

Merged
merged 2 commits into from
Oct 21, 2023

Conversation

kbumsik
Copy link
Contributor

@kbumsik kbumsik commented Sep 21, 2023

should have asChild when a button used.

<DisalogTrigger> should have asChild when a button used.
@vercel
Copy link

vercel bot commented Sep 21, 2023

@kbumsik is attempting to deploy a commit to the shadcn-pro Team on Vercel.

A member of the Team first needs to authorize it.

Copy link
Collaborator

@shadcn shadcn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch. Thank you.

@shadcn shadcn added bug Something isn't working area: examples automerge labels Oct 21, 2023
@vercel
Copy link

vercel bot commented Oct 21, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 21, 2023 0:39am

@kodiakhq kodiakhq bot merged commit cf0dada into shadcn-ui:main Oct 21, 2023
8 checks passed
kjxbyz pushed a commit to muse-ui/muse-ui that referenced this pull request Jun 7, 2024
<DisalogTrigger> should have asChild when a button used.
artabr pushed a commit to artabr/shadcn-ui that referenced this pull request Dec 15, 2024
<DisalogTrigger> should have asChild when a button used.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: examples automerge bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants