Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Upgrade to Node v20 #1968

Closed
wants to merge 6 commits into from
Closed

chore: Upgrade to Node v20 #1968

wants to merge 6 commits into from

Conversation

elliot
Copy link
Contributor

@elliot elliot commented Nov 17, 2023

Node v16 ended support on 11 Sep 2023.

This PR

  • Updates .nvmrc from 16 to 20
  • Updates actions/checkout from v3 to v4
  • Updates actions/setup-node from v2 to v4
    • Includes support for automatically caching pnpm dependencies, simplifying the workflow
  • Relaxes pnpm version constraint

Note

There is a warning for TypeError: The "code" argument must be of type number. Received an instance of Object which will be fixed in the PR below. It does not appear to affect typechecking

Copy link

vercel bot commented Nov 17, 2023

@elliot is attempting to deploy a commit to the shadcn-pro Team on Vercel.

A member of the Team first needs to authorize it.

@elliot
Copy link
Contributor Author

elliot commented Dec 3, 2023

@shadcn CI issue with sharp fixed

@elliot elliot closed this Mar 9, 2024
@trivikr
Copy link

trivikr commented Sep 8, 2024

I was just searching for popular repositories which still use end-of-life Node.js versions, and came across this PR.
Any update on when shadcn-ui/ui will switch to using supported version of Node.js, like 20.x?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants