Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: added event.preventdefault to stop page reload #2208

Closed
wants to merge 1 commit into from
Closed

fix: added event.preventdefault to stop page reload #2208

wants to merge 1 commit into from

Conversation

viruop
Copy link

@viruop viruop commented Dec 27, 2023

This pull request addresses unnecessary page reload issue on landing page of website.

Changes Made

  • Added event.preventDefault() to the form submission to prevent page reload.

Copy link

vercel bot commented Dec 27, 2023

@viruop is attempting to deploy a commit to the shadcn-pro Team on Vercel.

A member of the Team first needs to authorize it.

@shadcn
Copy link
Collaborator

shadcn commented Jan 7, 2024

@viruop I merged #2278 with a similar fix. Sorry I did not see this one.

@shadcn shadcn closed this Jan 7, 2024
@viruop
Copy link
Author

viruop commented Feb 22, 2024

@shadcn This PR is for a different component. The issue still persists on the live website. Please see the attached screenshot for more information.
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants